Return-Path: Received: from mail.kernel.org ([198.145.29.99]:41900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbeAaM31 (ORCPT ); Wed, 31 Jan 2018 07:29:27 -0500 Message-ID: <1517401762.3612.0.camel@kernel.org> Subject: Re: [PATCH v2] iversion: make inode_cmp_iversion{+raw} return bool instead of s64 From: Jeff Layton To: Linus Torvalds Cc: linux-fsdevel , Linux Kernel Mailing List , Al Viro , Linux NFS Mailing List , linux-ext4@vger.kernel.org, Theodore Ts'o , linux-xfs , linux-btrfs , linux-integrity , Trond Myklebust Date: Wed, 31 Jan 2018 07:29:22 -0500 In-Reply-To: References: <20180130173126.2806-1-jlayton@kernel.org> <20180130203221.29310-1-jlayton@kernel.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, 2018-01-30 at 12:53 -0800, Linus Torvalds wrote: > Ack. Should I expect this in a future pull request, or take it directly? > > There's no hurry about this, since none of the existing users of that > function actually do anything but test the return value against zero, > and nobody saves it into anything but a "bool" (which has magical > casting properties and does not lose upper bits). > > Linus Do you mind just taking it directly? I don't have anything else queued up for this cycle. Thanks, -- Jeff Layton