Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38940 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1031611AbeBNPmK (ORCPT ); Wed, 14 Feb 2018 10:42:10 -0500 From: "Benjamin Coddington" To: "Trond Myklebust" Cc: jlayton@redhat.com, aglo@umich.edu, linux-nfs@vger.kernel.org Subject: Re: [PATCH 1/2] NFSv4: Fix CLOSE races with OPEN Date: Wed, 14 Feb 2018 10:42:08 -0500 Message-ID: In-Reply-To: <1518622194.4737.1.camel@primarydata.com> References: <1479140396-17779-1-git-send-email-trond.myklebust@primarydata.com> <1479140396-17779-2-git-send-email-trond.myklebust@primarydata.com> <698A2B0C-1E38-4B65-ABA3-60C396393E30@redhat.com> <1518621683.13566.5.camel@redhat.com> <1518622194.4737.1.camel@primarydata.com> MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 14 Feb 2018, at 10:29, Trond Myklebust wrote: > On Wed, 2018-02-14 at 10:21 -0500, Jeff Layton wrote: >> On Wed, 2018-02-14 at 10:05 -0500, Benjamin Coddington wrote: >>> Hi Olga, >>> >>> On 13 Feb 2018, at 15:08, Olga Kornievskaia wrote: >>> >>>> On Mon, Nov 14, 2016 at 11:19 AM, Trond Myklebust >>>> wrote: >>>> ... >>> Ah, good question there.. Even though the stateid is not useful >>> for >>> operations that follow, I think the sequenceid should be >>> incremented because >>> the CLOSE is an operation that modifies the set of locks or state: >>> >> >> It doesn't matter. Yes, good condensed point. It doesn't matter. >>> ... > Is there a proposal to change the current client behaviour here? As far > as I can tell, the answer is "no". Am I missing something? Not that I can see. I think we're just comparing linux and netapp server behaviors.. Ben