Return-Path: Received: from mail-ua0-f193.google.com ([209.85.217.193]:36851 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158AbeBVAMd (ORCPT ); Wed, 21 Feb 2018 19:12:33 -0500 Received: by mail-ua0-f193.google.com with SMTP id i15so2232482uak.3 for ; Wed, 21 Feb 2018 16:12:32 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <6be06ce5-87e6-0d9d-55b9-6c70c3578ecf@maciej.szmigiero.name> From: Kees Cook Date: Wed, 21 Feb 2018 16:12:29 -0800 Message-ID: Subject: Re: RANDSTRUCT structs need linux/compiler_types.h (Was: [nfsd4] potentially hardware breaking regression in 4.14-rc and 4.13.11) To: Linus Torvalds Cc: "Maciej S. Szmigiero" , Patrick McLean , Emese Revfy , Al Viro , Bruce Fields , "Darrick J. Wong" , Linux Kernel Mailing List , Linux NFS Mailing List , Thorsten Leemhuis , "kernel-hardening@lists.openwall.com" Content-Type: text/plain; charset="UTF-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Feb 21, 2018 at 3:24 PM, Linus Torvalds wrote: > On Wed, Feb 21, 2018 at 2:52 PM, Kees Cook wrote: >> >> I'll play with Linus's suggestion and see what we get. > > It may be just as well to just include from > and be done with it. Hah, yeah, that would certainly solve it too. :) > I do hate including unnecessary stuff because it makes builds slower, > but kernel header files probably don't get much more core than > . It also has the benefit of not letting it "go wrong" in the first place. (And the separate fix for nfs isn't needed...) Do you want me to send the patch for this, or do you already have it prepared? The body-fields I had prepared for the nfs were: Reported-by: Patrick McLean Reported-by: Maciej S. Szmigiero Fixes: 3859a271a003 ("randstruct: Mark various structs for randomization") -Kees -- Kees Cook Pixel Security