Return-Path: Received: from mail-ua0-f193.google.com ([209.85.217.193]:47097 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbeBVAX2 (ORCPT ); Wed, 21 Feb 2018 19:23:28 -0500 Received: by mail-ua0-f193.google.com with SMTP id n48so2238169uae.13 for ; Wed, 21 Feb 2018 16:23:28 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <6be06ce5-87e6-0d9d-55b9-6c70c3578ecf@maciej.szmigiero.name> From: Kees Cook Date: Wed, 21 Feb 2018 16:23:26 -0800 Message-ID: Subject: Re: RANDSTRUCT structs need linux/compiler_types.h (Was: [nfsd4] potentially hardware breaking regression in 4.14-rc and 4.13.11) To: Linus Torvalds Cc: "Maciej S. Szmigiero" , Patrick McLean , Emese Revfy , Al Viro , Bruce Fields , "Darrick J. Wong" , Linux Kernel Mailing List , Linux NFS Mailing List , Thorsten Leemhuis , "kernel-hardening@lists.openwall.com" Content-Type: text/plain; charset="UTF-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Feb 21, 2018 at 4:22 PM, Linus Torvalds wrote: > On Wed, Feb 21, 2018 at 4:12 PM, Kees Cook wrote: >> >> Do you want me to send the patch for this, or do you already have it >> prepared? > > I'd rather get something explicitly tested. I tried my earlier patch > with "make allmodconfig" (and a fix to nfsd to make it compile), but > now I'm back to testing hjl's gas updates so it would be better to get > a tested commit with a good commit message. > >> The body-fields I had prepared for the nfs were: >> >> Reported-by: Patrick McLean >> Reported-by: Maciej S. Szmigiero > > Oh, I think Maciej needs to get more than a "Reported-by:". This was a > really subtle thing that we didn't figure out in the original thread, > so give him a gold star in the form of "Root-caused-by:" or something. Oops, I just sent this out. I will adjust a re-send. I couldn't find a documented field name for this... > *Fixing* this ends up being a one-liner or so. Finding the cause was > the painful part. Yes indeed! -Kees -- Kees Cook Pixel Security