Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:41264 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbeBWOVm (ORCPT ); Fri, 23 Feb 2018 09:21:42 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CCA158CDB for ; Fri, 23 Feb 2018 14:21:42 +0000 (UTC) Received: from steved.boston.devel.redhat.com (ovpn-116-20.phx2.redhat.com [10.3.116.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 98CFA600CC for ; Fri, 23 Feb 2018 14:21:42 +0000 (UTC) Subject: Re: [PATCH 0/7] nfs-utils: Use -Werror warning flags to clean up the code. To: Linux NFS Mailing list References: <20180220185034.26301-1-steved@redhat.com> From: Steve Dickson Message-ID: Date: Fri, 23 Feb 2018 09:21:42 -0500 MIME-Version: 1.0 In-Reply-To: <20180220185034.26301-1-steved@redhat.com> Content-Type: text/plain; charset=utf-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 02/20/2018 01:50 PM, Steve Dickson wrote: > I received a patch that tried to turns on some > of these -Werror flags but could not get passed > the warning that were being generated by > the rpcgen code. > > After taking care of the rpcgen warnings, I > took over the patch and finished it off. > > The warning flags I choose to use are pattern > after the list in the libostree and the > systemd list. > > Steve Dickson (7): > configure.ac: clean up > Removed missing-prototypes warnings. > Removed format-overflow=2 warnings > Removed format=2 warnings > Removed undef warnings > Removed missing-include-dirs warnings > Added more -Werror= warning flags > > configure.ac | 41 ++++++++++++++++++++++++-------------- > support/misc/mountpoint.c | 1 + > support/nfs/atomicio.c | 2 ++ > support/nfs/cacheio.c | 2 +- > support/nfs/closeall.c | 2 ++ > support/nfs/rpcmisc.c | 1 + > support/nfs/strlcat.c | 2 ++ > support/nfs/strlcpy.c | 2 ++ > support/nfs/svc_socket.c | 2 ++ > support/nfs/wildmat.c | 7 +++++++ > support/nfsidmap/libnfsidmap.c | 3 ++- > support/nfsidmap/nfsidmap_plugin.h | 1 + > support/nfsidmap/nss.c | 2 +- > systemd/systemd.c | 1 + > utils/blkmapd/device-discovery.c | 10 +++++----- > utils/blkmapd/dm-device.c | 2 +- > utils/gssd/Makefile.am | 2 ++ > utils/gssd/err_util.c | 1 + > utils/gssd/gss_names.c | 1 + > utils/gssd/gssd_proc.c | 4 ++-- > utils/gssd/krb5_util.c | 6 +++--- > utils/gssd/svcgssd.c | 4 ++-- > utils/gssd/svcgssd_mech2file.c | 1 + > utils/idmapd/Makefile.am | 2 ++ > utils/idmapd/idmapd.c | 4 ++-- > utils/mount/configfile.c | 4 ++++ > utils/mount/mount_libmount.c | 2 ++ > utils/mount/stropts.c | 2 ++ > utils/mountd/svc_run.c | 1 + > utils/nfsdcltrack/sqlite.c | 3 ++- > utils/nfsidmap/Makefile.am | 2 ++ > utils/nfsstat/nfsstat.c | 4 +++- > utils/statd/svc_run.c | 1 + > 33 files changed, 90 insertions(+), 35 deletions(-) > Series committed... steved.