Return-Path: Received: from fieldses.org ([173.255.197.46]:44242 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbeCHVjE (ORCPT ); Thu, 8 Mar 2018 16:39:04 -0500 Date: Thu, 8 Mar 2018 16:39:04 -0500 From: "bfields@fieldses.org" To: Scott Mayhew Cc: Trond Myklebust , "anna.schumaker@netapp.com" , "linux-nfs@vger.kernel.org" Subject: Re: [PATCH] nfs: nfs_commit_inode should redirty inode if the inode has outstanding requests Message-ID: <20180308213904.GD16485@fieldses.org> References: <20180302160038.1598-1-smayhew@redhat.com> <20180305211619.GA29226@fieldses.org> <1520286491.21829.13.camel@primarydata.com> <20180307195313.kzqdboqk5j2hyrf3@tonberry.usersys.redhat.com> <1520455098.2858.4.camel@primarydata.com> <20180308130901.h2qbbzsuejggogut@tonberry.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180308130901.h2qbbzsuejggogut@tonberry.usersys.redhat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Mar 08, 2018 at 08:09:01AM -0500, Scott Mayhew wrote: > Yes, this works. I ran it through a dozen fio runs on v4.1 and 1000 runs > of generic/247 on v3/v4.0/v4.1/v4.2 and didn't see any EBUSY errors. > Also ran the xfstests "quick" group (~80-90 tests) plus generic/074 on > v3/v4.0/v4.1/v4.2. Finally, I double checked the panic on umount issue > that dc4fd9ab01ab3 fixed and that still works too. Works for me too. (Yeah, I see there's a new patch. Testing queued up but not run yet...). --b.