Return-Path: Received: from us-smtp-delivery-194.mimecast.com ([216.205.24.194]:39800 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbeCLMcw (ORCPT ); Mon, 12 Mar 2018 08:32:52 -0400 From: Trond Myklebust To: "smayhew@redhat.com" CC: "bfields@fieldses.org" , "anna.schumaker@netapp.com" , "linux-nfs@vger.kernel.org" Subject: Re: [PATCH] nfs: nfs_commit_inode should redirty inode if the inode has outstanding requests Date: Mon, 12 Mar 2018 12:32:46 +0000 Message-ID: <1520857965.3554.0.camel@primarydata.com> References: <20180302160038.1598-1-smayhew@redhat.com> <20180305211619.GA29226@fieldses.org> <1520286491.21829.13.camel@primarydata.com> <20180307195313.kzqdboqk5j2hyrf3@tonberry.usersys.redhat.com> <1520455098.2858.4.camel@primarydata.com> <20180308130901.h2qbbzsuejggogut@tonberry.usersys.redhat.com> <1520529236.3530.16.camel@primarydata.com> <20180312120704.a5ot7zd26vbbiehf@tonberry.usersys.redhat.com> In-Reply-To: <20180312120704.a5ot7zd26vbbiehf@tonberry.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gTW9uLCAyMDE4LTAzLTEyIGF0IDA4OjA3IC0wNDAwLCBTY290dCBNYXloZXcgd3JvdGU6DQo+ IE9uIFRodSwgMDggTWFyIDIwMTgsIFRyb25kIE15a2xlYnVzdCB3cm90ZToNCj4gDQo+ID4gT24g VGh1LCAyMDE4LTAzLTA4IGF0IDA4OjA5IC0wNTAwLCBTY290dCBNYXloZXcgd3JvdGU6DQo+ID4g PiBZZXMsIHRoaXMgd29ya3MuICBJIHJhbiBpdCB0aHJvdWdoIGEgZG96ZW4gZmlvIHJ1bnMgb24g djQuMSBhbmQNCj4gPiA+IDEwMDANCj4gPiA+IHJ1bnMNCj4gPiA+IG9mIGdlbmVyaWMvMjQ3IG9u IHYzL3Y0LjAvdjQuMS92NC4yIGFuZCBkaWRuJ3Qgc2VlIGFueSBFQlVTWQ0KPiA+ID4gZXJyb3Jz Lg0KPiA+ID4gQWxzbyByYW4gdGhlIHhmc3Rlc3RzICJxdWljayIgZ3JvdXAgKH44MC05MCB0ZXN0 cykgcGx1cw0KPiA+ID4gZ2VuZXJpYy8wNzQNCj4gPiA+IG9uDQo+ID4gPiB2My92NC4wL3Y0LjEv djQuMi4gIEZpbmFsbHksIEkgZG91YmxlIGNoZWNrZWQgdGhlIHBhbmljIG9uIHVtb3VudA0KPiA+ ID4gaXNzdWUNCj4gPiA+IHRoYXQgZGM0ZmQ5YWIwMWFiMyBmaXhlZCBhbmQgdGhhdCBzdGlsbCB3 b3JrcyB0b28uDQo+ID4gDQo+ID4gSSB0b29rIGEgbG9uZyBoYXJkIGxvb2sgYXQgd2hhdCB3ZSBh Y3R1YWxseSBuZWVkIGluIHRoYXQgYXJlYSBvZg0KPiA+IHRoZQ0KPiA+IGNvZGUuIFRoZXJlIGFy ZSBhIGZldyB0aGluZ3MgdGhhdCBhcmUgc3RpbGwgYnJva2VuIHRoZXJlOg0KPiA+IA0KPiA+IEZp cnN0bHksIHdlIHdhbnQgdG8ga2VlcCB0aGUgaW5vZGUgbWFya2VkIGFzIElfRElSVFlfREFUQVNZ TkMgYXMNCj4gPiBsb25nDQo+ID4gYXMgd2UgaGF2ZSBzdGFibGUgd3JpdGVzIHRoYXQgYXJlIHVu ZGVyZ29pbmcgY29tbWl0IG9yIGFyZSB3YWl0aW5nDQo+ID4gdG8NCj4gPiBiZSBzY2hlZHVsZWQu IFRoZSByZWFzb24gaXMgdGhhdCBlbnN1cmVzIHN5bmNfaW5vZGUoKSBiZWhhdmVzDQo+ID4gY29y cmVjdGx5DQo+ID4gYnkgY2FsbGluZyBpbnRvIG5mc193cml0ZV9pbm9kZSgpIHNvIHRoYXQgd2Ug Y2FuIHNjaGVkdWxlIENPTU1JVHMNCj4gPiBhbmQNCj4gPiB3YWl0IGZvciB0aGVtIGFsbCB0byBj b21wbGV0ZS4NCj4gPiBDdXJyZW50bHkgd2UgYXJlIGJyb2tlbiBpbiB0aGF0IG5mc193cml0ZV9p bm9kZSgpIHdpbGwgbm90IHJlc2V0DQo+ID4gSV9ESVJUWV9EQVRBU1lOQyBpZiB0aGVyZSBhcmUg c3RpbGwgQ09NTUlUcyBpbiBmbGlnaHQgZHVlIHRvIGhhdmluZw0KPiA+IGNhbGxlZCBpdCB3aXRo IHdiYy0+c3luY19tb2RlID09IFdCX1NZTkNfTk9ORS4NCj4gPiANCj4gPiBTZWNvbmRseSwgd2Ug d2FudCB0byBlbnN1cmUgdGhhdCBpZiB0aGUgbnVtYmVyIG9mIHJlcXVlc3RzIGlzID4NCj4gPiBJ TlRfTUFYLCB3ZSBsb29wIGFyb3VuZCBhbmQgc2NoZWR1bGUgbW9yZSBDT01NSVRzIHNvIHRoYXQN Cj4gPiBuZnNfY29tbWl0X2lub2RlKGlub2RlLCBGTFVTSF9TWU5DKSBpcyByZWxpYWJsZSBvbiBz eXN0ZW1zIHdpdGgNCj4gPiBsb3RzIG9mDQo+ID4gbWVtb3J5Lg0KPiA+IA0KPiA+IEZpbmFsbHks IGl0IGlzIHdvcnRoIG5vdGluZyB0aGF0IGl0J3Mgb25seSB3aGVuIGNhbGxlZCBmcm9tDQo+ID4g X193cml0ZWJhY2tfc2luZ2xlX2lub2RlKCksIGFuZCB0aGUgYXR0ZW1wdCB0byBjbGVhbiB0aGUg aW5vZGUNCj4gPiBmYWlsZWQNCj4gPiB0aGF0IHdlIG5lZWQgdG8gcmVzZXQgdGhlIGlub2RlIHN0 YXRlLiBTbyB3ZSBjYW4gb3B0aW1pc2UgYnkNCj4gPiBwdXNoaW5nDQo+ID4gdGhvc2UgY2FsbHMg dG8gX19tYXJrX2lub2RlX2RpcnR5KCkgaW50byBuZnNfd3JpdGVfaW5vZGUoKS4NCj4gPiANCj4g PiBTbyBob3cgYWJvdXQgdGhlIGZvbGxvd2luZyB2MiBwYXRjaCBpbnN0ZWFkPw0KPiA+IDg8LS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gPiBGcm9tIDM4Njk3 OGNjM2VmNDQ5NGI5Zjk1MzkwNzQ3YzIyNjhmODMxOGI5NGIgTW9uIFNlcCAxNyAwMDowMDowMA0K PiA+IDIwMDENCj4gPiBGcm9tOiBUcm9uZCBNeWtsZWJ1c3QgPHRyb25kLm15a2xlYnVzdEBwcmlt YXJ5ZGF0YS5jb20+DQo+ID4gRGF0ZTogV2VkLCA3IE1hciAyMDE4IDE1OjIyOjMxIC0wNTAwDQo+ ID4gU3ViamVjdDogW1BBVENIIHYyXSBORlM6IEZpeCB1bnN0YWJsZSB3cml0ZSBjb21wbGV0aW9u DQo+ID4gDQo+ID4gV2UgZG8gd2FudCB0byByZXNwZWN0IHRoZSBGTFVTSF9TWU5DIGFyZ3VtZW50 IHRvIG5mc19jb21taXRfaW5vZGUoKQ0KPiA+IHRvDQo+ID4gZW5zdXJlIHRoYXQgYWxsIG91dHN0 YW5kaW5nIENPTU1JVCByZXF1ZXN0cyB0byB0aGUgaW5vZGUgaW4NCj4gPiBxdWVzdGlvbiBhcmUN Cj4gPiBjb21wbGV0ZS4gQ3VycmVudGx5IHdlIG1heSBleGl0IGVhcmx5IGZyb20gYm90aCBuZnNf Y29tbWl0X2lub2RlKCkNCj4gPiBhbmQNCj4gPiBuZnNfd3JpdGVfaW5vZGUoKSBldmVuIGlmIHRo ZXJlIGFyZSBDT01NSVQgcmVxdWVzdHMgaW4gZmxpZ2h0LCBvcg0KPiA+IHVuc3RhYmxlDQo+ID4g d3JpdGVzIG9uIHRoZSBjb21taXQgbGlzdC4NCj4gPiANCj4gPiBJbiBvcmRlciB0byBnZXQgdGhl IHJpZ2h0IHNlbWFudGljcyB3LnIudC4gc3luY19pbm9kZSgpLCB3ZSBkb24ndA0KPiA+IG5lZWQN Cj4gPiB0byBoYXZlIG5mc19jb21taXRfaW5vZGUoKSByZXNldCB0aGUgaW5vZGUgZGlydHkgZmxh Z3Mgd2hlbiBjYWxsZWQNCj4gPiBmcm9tDQo+ID4gbmZzX3diX3BhZ2UoKSBhbmQvb3IgbmZzX3di X2FsbCgpLiBXZSBqdXN0IG5lZWQgdG8gZW5zdXJlIHRoYXQNCj4gPiBuZnNfd3JpdGVfaW5vZGUo KSBsZWF2ZXMgdGhlbSBpbiB0aGUgcmlnaHQgc3RhdGUgaWYgdGhlcmUgYXJlDQo+ID4gb3V0c3Rh bmRpbmcNCj4gPiBjb21taXRzLCBvciBzdGFibGUgcGFnZXMuDQo+ID4gDQo+ID4gUmVwb3J0ZWQt Ynk6IFNjb3R0IE1heWhldyA8c21heWhld0ByZWRoYXQuY29tPg0KPiA+IEZpeGVzOiBkYzRmZDlh YjAxYWIgKCJuZnM6IGRvbid0IHdhaXQgb24gY29tbWl0IGluDQo+ID4gbmZzX2NvbW1pdF9pbm9k ZSgpLi4uIikNCj4gPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZyAjIHY0LjUrOiA1Y2I5NTNk NGIxZTc6IE5GUzogVXNlIGFuDQo+ID4gYXRvbWljX2xvbmdfdA0KPiA+IENjOiBzdGFibGVAdmdl ci5rZXJuZWwub3JnICMgdjQuNSsNCj4gPiBTaWduZWQtb2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3Qg PHRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20+DQo+IA0KPiBJIHJhbiBhbGwgdGhlIHNh bWUgdGVzdHMgYXMgYmVmb3JlIGFuZCB0aGlzIGlzIHdvcmtpbmcgZmluZS4NCj4gDQoNClRoYW5r cyBTY290dCENCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRh aW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg==