Return-Path: Received: from us-smtp-delivery-194.mimecast.com ([63.128.21.194]:44853 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbeCLNHP (ORCPT ); Mon, 12 Mar 2018 09:07:15 -0400 From: Trond Myklebust To: "tom@talpey.com" , "anna.schumaker@netapp.com" , "jlayton@redhat.com" , "chuck.lever@oracle.com" CC: "linux-rdma@vger.kernel.org" , "linux-nfs@vger.kernel.org" Subject: Re: [PATCH v2] SUNRPC: Initialize rpc_rqst outside of xprt->reserve_lock Date: Mon, 12 Mar 2018 13:07:09 +0000 Message-ID: <1520860026.3554.7.camel@primarydata.com> References: <20180311152620.16974.96109.stgit@manet.1015granger.net> <0141adad-602c-70d0-08d6-e33b954cc163@talpey.com> <1520852218.4440.2.camel@redhat.com> In-Reply-To: <1520852218.4440.2.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gTW9uLCAyMDE4LTAzLTEyIGF0IDA2OjU2IC0wNDAwLCBKZWZmIExheXRvbiB3cm90ZToNCj4g SXQgaXMgb3BhcXVlLiBCdXQsIGl0J3MgaGVscGZ1bCB0byB0cmVhdCBpdCBhcyBpZiBpdCBoYXMg ZW5kaWFubmVzcywNCj4gaWYNCj4gb25seSB0byBtYWtlIGxvZ2ZpbGVzLCB0cmFjZXMgYW5kIHN1 Y2ggbG9vayBjb25zaXN0ZW50IHdoZW4gKGUuZy4pDQo+IHRoZQ0KPiBjbGllbnQgYW5kIHNlcnZl ciBhcmUgZGlmZmVyZW50IGVuZGlhbm5lc3MuDQoNCkFncmVlZC4gVGhlIG90aGVyIHRoaW5nIHRv IG5vdGUgaXMgdGhhdCBhbGwgbmF0aXZlIFhEUiBvYmplY3RzIGFyZQ0KYW5ub3RhdGVkIGFzIGJl aW5nIGJpZyBlbmRpYW4gaW4gb3JkZXIgdG8gYWxsb3cgJ3NwYXJzZScgYW5kIG90aGVyDQpzdGF0 aWMgdHlwZSBjaGVja2VycyB0byBpZGVudGlmeSBkb2RneSBjYXN0cyBhbmQgZmFpbHVyZXMgdG8g Y29udmVydA0KdGhlIGVuZGlhbm5lc3MuDQpTbyBieSBsYWJlbGxpbmcgdGhlIFhJRCBhcyBfX2Jl MzIsIHdlJ3JlIGluIGVmZmVjdCB0ZWxsaW5nIHRob3NlDQpjaGVja2VycyB0aGF0IHdlIGRvIG5v dCBuZWVkIHRvIGNvbnZlcnQgdGhpcyBvYmplY3Qgd2hlbiBYRFIgZW5jb2RpbmcNCml0Lg0KDQpD aGVlcnMNCiAgVHJvbmQNCg0KPiANCj4gT24gU3VuLCAyMDE4LTAzLTExIGF0IDE3OjQxIC0wNzAw LCBUb20gVGFscGV5IHdyb3RlOg0KPiA+ICA+ICtzdGF0aWMgX19iZTMyCXhwcnRfYWxsb2NfeGlk KHN0cnVjdCBycGNfeHBydCAqeHBydCk7DQo+ID4gDQo+ID4gV2h5IGlzIHRoZSB0eXBlIGEgYmUz Mj8gVGhlIFhJRCBpcyBvcGFxdWUsIHRlc3RlZCBvbmx5IGZvcg0KPiA+IGVxdWFsaXR5LCBhbmQN Cj4gPiBubyBieXRlIG9yZGVyIGlzIGRlZmluZWQgYnkgdGhlIFJQQyBwcm90b2NvbC4NCj4gPiAN Cj4gPiBNZXRoaW5rcyBpdCBzaG91bGQgYmUgdTMyLg0KPiA+IA0KPiA+IFRvbS4NCj4gPiANCj4g PiBPbiAzLzExLzIwMTggODoyNyBBTSwgQ2h1Y2sgTGV2ZXIgd3JvdGU6DQo+ID4gPiBhbGxvY19z bG90IGlzIGEgdHJhbnNwb3J0LXNwZWNpZmljIG9wLCBidXQgaW5pdGlhbGl6aW5nIGFuDQo+ID4g PiBycGNfcnFzdA0KPiA+ID4gaXMgY29tbW9uIHRvIGFsbCB0cmFuc3BvcnRzLiBJbiBhZGRpdGlv biwgdGhlIG9ubHkgcGFydCBvZg0KPiA+ID4gaW5pdGlhbC0NCj4gPiA+IGl6aW5nIGFuIHJwY19y cXN0IHRoYXQgbmVlZHMgc2VyaWFsaXphdGlvbiBpcyBnZXR0aW5nIGEgZnJlc2gNCj4gPiA+IFhJ RC4NCj4gPiA+IA0KPiA+ID4gTW92ZSBycGNfcnFzdCBpbml0aWFsaXphdGlvbiB0byBjb21tb24g Y29kZSBpbiBwcmVwYXJhdGlvbiBmb3INCj4gPiA+IGFkZGluZyBhIHRyYW5zcG9ydC1zcGVjaWZp YyBhbGxvY19zbG90IHRvIHhwcnRyZG1hLg0KPiA+ID4gDQo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBD aHVjayBMZXZlciA8Y2h1Y2subGV2ZXJAb3JhY2xlLmNvbT4NCj4gPiA+IC0tLQ0KPiA+ID4gICBp bmNsdWRlL2xpbnV4L3N1bnJwYy94cHJ0LmggfCAgICAxICsNCj4gPiA+ICAgbmV0L3N1bnJwYy9j bG50LmMgICAgICAgICAgIHwgICAgMSArDQo+ID4gPiAgIG5ldC9zdW5ycGMveHBydC5jICAgICAg ICAgICB8ICAgMTIgKysrKysrKy0tLS0tDQo+ID4gPiAgIDMgZmlsZXMgY2hhbmdlZCwgOSBpbnNl cnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQ0KPiA+ID4gDQo+ID4gPiBDaGFuZ2VzIHNpbmNlIHYx Og0KPiA+ID4gLSBQYXJ0aWFsIHNlbmRzIHNob3VsZCBub3QgYnVtcCB0aGUgWElEDQo+ID4gPiAN Cj4gPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3N1bnJwYy94cHJ0LmgNCj4gPiA+IGIv aW5jbHVkZS9saW51eC9zdW5ycGMveHBydC5oDQo+ID4gPiBpbmRleCA1ZmVhMGZiLi45Nzg0ZTI4 IDEwMDY0NA0KPiA+ID4gLS0tIGEvaW5jbHVkZS9saW51eC9zdW5ycGMveHBydC5oDQo+ID4gPiAr KysgYi9pbmNsdWRlL2xpbnV4L3N1bnJwYy94cHJ0LmgNCj4gPiA+IEBAIC0zMjQsNiArMzI0LDcg QEAgc3RydWN0IHhwcnRfY2xhc3Mgew0KPiA+ID4gICBzdHJ1Y3QgcnBjX3hwcnQJCSp4cHJ0X2Ny ZWF0ZV90cmFuc3BvcnQoc3RydWN0DQo+ID4gPiB4cHJ0X2NyZWF0ZSAqYXJncyk7DQo+ID4gPiAg IHZvaWQJCQl4cHJ0X2Nvbm5lY3Qoc3RydWN0IHJwY190YXNrDQo+ID4gPiAqdGFzayk7DQo+ID4g PiAgIHZvaWQJCQl4cHJ0X3Jlc2VydmUoc3RydWN0IHJwY190YXNrDQo+ID4gPiAqdGFzayk7DQo+ ID4gPiArdm9pZAkJCXhwcnRfcmVxdWVzdF9pbml0KHN0cnVjdCBycGNfdGFzaw0KPiA+ID4gKnRh c2spOw0KPiA+ID4gICB2b2lkCQkJeHBydF9yZXRyeV9yZXNlcnZlKHN0cnVjdCBycGNfdGFzaw0K PiA+ID4gKnRhc2spOw0KPiA+ID4gICBpbnQJCQl4cHJ0X3Jlc2VydmVfeHBydChzdHJ1Y3QgcnBj X3hwcnQNCj4gPiA+ICp4cHJ0LCBzdHJ1Y3QgcnBjX3Rhc2sgKnRhc2spOw0KPiA+ID4gICBpbnQJ CQl4cHJ0X3Jlc2VydmVfeHBydF9jb25nKHN0cnVjdA0KPiA+ID4gcnBjX3hwcnQgKnhwcnQsIHN0 cnVjdCBycGNfdGFzayAqdGFzayk7DQo+ID4gPiBkaWZmIC0tZ2l0IGEvbmV0L3N1bnJwYy9jbG50 LmMgYi9uZXQvc3VucnBjL2NsbnQuYw0KPiA+ID4gaW5kZXggNmU0MzJlYy4uMjI2ZjU1OCAxMDA2 NDQNCj4gPiA+IC0tLSBhL25ldC9zdW5ycGMvY2xudC5jDQo+ID4gPiArKysgYi9uZXQvc3VucnBj L2NsbnQuYw0KPiA+ID4gQEAgLTE1NDYsNiArMTU0Niw3IEBAIHZvaWQgcnBjX2ZvcmNlX3JlYmlu ZChzdHJ1Y3QgcnBjX2NsbnQNCj4gPiA+ICpjbG50KQ0KPiA+ID4gICAJdGFzay0+dGtfc3RhdHVz ID0gMDsNCj4gPiA+ICAgCWlmIChzdGF0dXMgPj0gMCkgew0KPiA+ID4gICAJCWlmICh0YXNrLT50 a19ycXN0cCkgew0KPiA+ID4gKwkJCXhwcnRfcmVxdWVzdF9pbml0KHRhc2spOw0KPiA+ID4gICAJ CQl0YXNrLT50a19hY3Rpb24gPSBjYWxsX3JlZnJlc2g7DQo+ID4gPiAgIAkJCXJldHVybjsNCj4g PiA+ICAgCQl9DQo+ID4gPiBkaWZmIC0tZ2l0IGEvbmV0L3N1bnJwYy94cHJ0LmMgYi9uZXQvc3Vu cnBjL3hwcnQuYw0KPiA+ID4gaW5kZXggNzBmMDA1MC4uMmQ5NTkyNiAxMDA2NDQNCj4gPiA+IC0t LSBhL25ldC9zdW5ycGMveHBydC5jDQo+ID4gPiArKysgYi9uZXQvc3VucnBjL3hwcnQuYw0KPiA+ ID4gQEAgLTY2LDcgKzY2LDcgQEANCj4gPiA+ICAgICogTG9jYWwgZnVuY3Rpb25zDQo+ID4gPiAg ICAqLw0KPiA+ID4gICBzdGF0aWMgdm9pZAkgeHBydF9pbml0KHN0cnVjdCBycGNfeHBydCAqeHBy dCwgc3RydWN0IG5ldA0KPiA+ID4gKm5ldCk7DQo+ID4gPiAtc3RhdGljIHZvaWQJeHBydF9yZXF1 ZXN0X2luaXQoc3RydWN0IHJwY190YXNrICosIHN0cnVjdA0KPiA+ID4gcnBjX3hwcnQgKik7DQo+ ID4gPiArc3RhdGljIF9fYmUzMgl4cHJ0X2FsbG9jX3hpZChzdHJ1Y3QgcnBjX3hwcnQgKnhwcnQp Ow0KPiA+ID4gICBzdGF0aWMgdm9pZAl4cHJ0X2Nvbm5lY3Rfc3RhdHVzKHN0cnVjdCBycGNfdGFz ayAqdGFzayk7DQo+ID4gPiAgIHN0YXRpYyBpbnQgICAgICBfX3hwcnRfZ2V0X2Nvbmcoc3RydWN0 IHJwY194cHJ0ICosIHN0cnVjdA0KPiA+ID4gcnBjX3Rhc2sgKik7DQo+ID4gPiAgIHN0YXRpYyB2 b2lkICAgICBfX3hwcnRfcHV0X2Nvbmcoc3RydWN0IHJwY194cHJ0ICosIHN0cnVjdA0KPiA+ID4g cnBjX3Jxc3QgKik7DQo+ID4gPiBAQCAtOTg3LDYgKzk4Nyw4IEBAIGJvb2wgeHBydF9wcmVwYXJl X3RyYW5zbWl0KHN0cnVjdCBycGNfdGFzaw0KPiA+ID4gKnRhc2spDQo+ID4gPiAgIAkJdGFzay0+ dGtfc3RhdHVzID0gLUVBR0FJTjsNCj4gPiA+ICAgCQlnb3RvIG91dF91bmxvY2s7DQo+ID4gPiAg IAl9DQo+ID4gPiArCWlmICghYmNfcHJlYWxsb2MocmVxKSAmJiAhcmVxLT5ycV94bWl0X2J5dGVz X3NlbnQpDQo+ID4gPiArCQlyZXEtPnJxX3hpZCA9IHhwcnRfYWxsb2NfeGlkKHhwcnQpOw0KPiA+ ID4gICAJcmV0ID0gdHJ1ZTsNCj4gPiA+ICAgb3V0X3VubG9jazoNCj4gPiA+ICAgCXNwaW5fdW5s b2NrX2JoKCZ4cHJ0LT50cmFuc3BvcnRfbG9jayk7DQo+ID4gPiBAQCAtMTE2MywxMCArMTE2NSwx MCBAQCB2b2lkIHhwcnRfYWxsb2Nfc2xvdChzdHJ1Y3QgcnBjX3hwcnQNCj4gPiA+ICp4cHJ0LCBz dHJ1Y3QgcnBjX3Rhc2sgKnRhc2spDQo+ID4gPiAgIG91dF9pbml0X3JlcToNCj4gPiA+ICAgCXhw cnQtPnN0YXQubWF4X3Nsb3RzID0gbWF4X3QodW5zaWduZWQgaW50LCB4cHJ0LQ0KPiA+ID4gPnN0 YXQubWF4X3Nsb3RzLA0KPiA+ID4gICAJCQkJICAgICB4cHJ0LT5udW1fcmVxcyk7DQo+ID4gPiAr CXNwaW5fdW5sb2NrKCZ4cHJ0LT5yZXNlcnZlX2xvY2spOw0KPiA+ID4gKw0KPiA+ID4gICAJdGFz ay0+dGtfc3RhdHVzID0gMDsNCj4gPiA+ICAgCXRhc2stPnRrX3Jxc3RwID0gcmVxOw0KPiA+ID4g LQl4cHJ0X3JlcXVlc3RfaW5pdCh0YXNrLCB4cHJ0KTsNCj4gPiA+IC0Jc3Bpbl91bmxvY2soJnhw cnQtPnJlc2VydmVfbG9jayk7DQo+ID4gPiAgIH0NCj4gPiA+ICAgRVhQT1JUX1NZTUJPTF9HUEwo eHBydF9hbGxvY19zbG90KTsNCj4gPiA+ICAgDQo+ID4gPiBAQCAtMTMwMyw4ICsxMzA1LDkgQEAg c3RhdGljIGlubGluZSB2b2lkIHhwcnRfaW5pdF94aWQoc3RydWN0DQo+ID4gPiBycGNfeHBydCAq eHBydCkNCj4gPiA+ICAgCXhwcnQtPnhpZCA9IHByYW5kb21fdTMyKCk7DQo+ID4gPiAgIH0NCj4g PiA+ICAgDQo+ID4gPiAtc3RhdGljIHZvaWQgeHBydF9yZXF1ZXN0X2luaXQoc3RydWN0IHJwY190 YXNrICp0YXNrLCBzdHJ1Y3QNCj4gPiA+IHJwY194cHJ0ICp4cHJ0KQ0KPiA+ID4gK3ZvaWQgeHBy dF9yZXF1ZXN0X2luaXQoc3RydWN0IHJwY190YXNrICp0YXNrKQ0KPiA+ID4gICB7DQo+ID4gPiAr CXN0cnVjdCBycGNfeHBydCAqeHBydCA9IHRhc2stPnRrX3hwcnQ7DQo+ID4gPiAgIAlzdHJ1Y3Qg cnBjX3Jxc3QJKnJlcSA9IHRhc2stPnRrX3Jxc3RwOw0KPiA+ID4gICANCj4gPiA+ICAgCUlOSVRf TElTVF9IRUFEKCZyZXEtPnJxX2xpc3QpOw0KPiA+ID4gQEAgLTEzMTIsNyArMTMxNSw2IEBAIHN0 YXRpYyB2b2lkIHhwcnRfcmVxdWVzdF9pbml0KHN0cnVjdA0KPiA+ID4gcnBjX3Rhc2sgKnRhc2ss IHN0cnVjdCBycGNfeHBydCAqeHBydCkNCj4gPiA+ICAgCXJlcS0+cnFfdGFzawk9IHRhc2s7DQo+ ID4gPiAgIAlyZXEtPnJxX3hwcnQgICAgPSB4cHJ0Ow0KPiA+ID4gICAJcmVxLT5ycV9idWZmZXIg ID0gTlVMTDsNCj4gPiA+IC0JcmVxLT5ycV94aWQgICAgID0geHBydF9hbGxvY194aWQoeHBydCk7 DQo+ID4gPiAgIAlyZXEtPnJxX2Nvbm5lY3RfY29va2llID0geHBydC0+Y29ubmVjdF9jb29raWUg LSAxOw0KPiA+ID4gICAJcmVxLT5ycV9ieXRlc19zZW50ID0gMDsNCj4gPiA+ICAgCXJlcS0+cnFf c25kX2J1Zi5sZW4gPSAwOw0KPiA+ID4gDQo+ID4gPiAtLQ0KPiA+ID4gVG8gdW5zdWJzY3JpYmUg ZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LQ0KPiA+ID4g bmZzIiBpbg0KPiA+ID4gdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtl cm5lbC5vcmcNCj4gPiA+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5l bC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtDQo+ID4gPiBsDQo+ID4gPiANCj4gPiA+IA0KPiA+IA0K PiA+IC0tDQo+ID4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUg InVuc3Vic2NyaWJlIGxpbnV4LQ0KPiA+IG5mcyIgaW4NCj4gPiB0aGUgYm9keSBvZiBhIG1lc3Nh Z2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZw0KPiA+IE1vcmUgbWFqb3Jkb21vIGluZm8g YXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbA0KPiANCj4gDQot LSANClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWludGFpbmVyLCBQcmltYXJ5 RGF0YQ0KdHJvbmQubXlrbGVidXN0QHByaW1hcnlkYXRhLmNvbQ0K