Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53756 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751482AbeDCOxN (ORCPT ); Tue, 3 Apr 2018 10:53:13 -0400 Subject: [PATCH net-next 0/3] fscache: quick review From: David Howells To: anna.schumaker@netapp.com, steved@redhat.com Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-afs@lists.infradead.org Date: Tue, 03 Apr 2018 15:53:12 +0100 Message-ID: <152276719197.15943.8722265175158239235.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: Hi Anna, Steve, Could you give these three patches a quick look over? They: (1) Modify the netfs->fscache API to store the index key, auxiliary data and data size in the cookie/object rather than calling back into the netfs - which reduces issues around making sure the netfs still exists. (2) Keep a list of all the cookies known to weed out duplicate cookies at the top. I'd ideally like to try getting them into this merge window. The patches can also be found on this branch on top of some other patches which add a few fixes and some tracepoints: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache-next Thanks, David --- David Howells (3): fscache: Attach the index key and aux data to the cookie fscache: Pass object size in rather than calling back for it fscache: Maintain a catalogue of allocated cookies Documentation/filesystems/caching/netfs-api.txt | 157 +++++------ fs/9p/cache.c | 100 ++----- fs/afs/cache.c | 142 ---------- fs/afs/cell.c | 6 fs/afs/file.c | 6 fs/afs/inode.c | 46 +++ fs/afs/internal.h | 7 fs/afs/volume.c | 6 fs/cachefiles/interface.c | 43 ++- fs/cachefiles/namei.c | 33 +- fs/cachefiles/xattr.c | 8 - fs/ceph/cache.c | 113 ++------ fs/cifs/cache.c | 168 ------------ fs/cifs/fscache.c | 130 +++++++-- fs/cifs/fscache.h | 13 + fs/fscache/cache.c | 2 fs/fscache/cookie.c | 336 +++++++++++++++++++---- fs/fscache/fsdef.c | 55 ---- fs/fscache/internal.h | 27 ++ fs/fscache/netfs.c | 23 -- fs/fscache/object-list.c | 28 +- fs/fscache/object.c | 27 +- fs/fscache/operation.c | 2 fs/fscache/page.c | 5 fs/nfs/fscache-index.c | 159 ----------- fs/nfs/fscache.c | 89 +++++- fs/nfs/fscache.h | 15 + include/linux/fscache-cache.h | 3 include/linux/fscache.h | 141 ++++++---- include/trace/events/fscache.h | 6 30 files changed, 926 insertions(+), 970 deletions(-)