Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:37408 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755252AbeFNQ22 (ORCPT ); Thu, 14 Jun 2018 12:28:28 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A7C0140122BD for ; Thu, 14 Jun 2018 16:28:27 +0000 (UTC) From: Kenneth Dsouza To: linux-nfs@vger.kernel.org Cc: steved@redhat.com Subject: [PATCH] nfs-utils: Fix a minor memory leak in generate_mount_unit and generate_target. Date: Thu, 14 Jun 2018 21:58:25 +0530 Message-Id: <20180614162825.25676-1-kdsouza@redhat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: Free allocated memory for path before return. Signed-off-by: Kenneth D'souza --- systemd/rpc-pipefs-generator.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/systemd/rpc-pipefs-generator.c b/systemd/rpc-pipefs-generator.c index 6e1d69c..0b5da11 100644 --- a/systemd/rpc-pipefs-generator.c +++ b/systemd/rpc-pipefs-generator.c @@ -35,7 +35,10 @@ static int generate_mount_unit(const char *pipefs_path, const char *pipefs_unit, sprintf(path, "%s/%s", dirname, pipefs_unit); f = fopen(path, "w"); if (!f) + { + free(path); return 1; + } fprintf(f, "# Automatically generated by rpc-pipefs-generator\n\n[Unit]\n"); fprintf(f, "Description=RPC Pipe File System\n"); @@ -48,6 +51,7 @@ static int generate_mount_unit(const char *pipefs_path, const char *pipefs_unit, fprintf(f, "Type=rpc_pipefs\n"); fclose(f); + free(path); return 0; } @@ -76,12 +80,16 @@ int generate_target(char *pipefs_path, const char *dirname) strcat(path, filebase); f = fopen(path, "w"); if (!f) + { + free(path); return 1; + } fprintf(f, "# Automatically generated by rpc-pipefs-generator\n\n[Unit]\n"); fprintf(f, "Requires=%s\n", pipefs_unit); fprintf(f, "After=%s\n", pipefs_unit); fclose(f); + free(path); return 0; } -- 2.14.3