Subject: Re: [PATCH] Revert "gssd.c: Remomved a couple of warning errors"
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20180627171252.18145-1-steved@redhat.com>
From: Steve Dickson <SteveD@RedHat.com>
Message-ID: <92f419fc-f442-b2dd-00e3-4c745aaf85d9@RedHat.com>
Date: Wed, 27 Jun 2018 14:14:45 -0400
MIME-Version: 1.0
In-Reply-To: <20180627171252.18145-1-steved@redhat.com>
Content-Type: text/plain; charset=utf-8
Sender: linux-nfs-owner@vger.kernel.org


On 06/27/2018 01:12 PM, Steve Dickson wrote:
> This reverts commit 98118f5e382cdeb1acf25370768d5dfdc254ba5d.
> Added back the 'm' character which cause memory to be
> allocated for the string convertions.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed... 

steved.

> ---
>  utils/gssd/gssd.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/utils/gssd/gssd.c b/utils/gssd/gssd.c
> index 7b21ee2..2c14e5f 100644
> --- a/utils/gssd/gssd.c
> +++ b/utils/gssd/gssd.c
> @@ -279,16 +279,16 @@ gssd_read_service_info(int dirfd, struct clnt_info *clp)
>  	 * (commit bf19aacecbeebccb2c3d150a8bd9416b7dba81fe)
>  	 */
>  	numfields = fscanf(info,
> -			   "RPC server: %s\n"
> -			   "service: %s (%d) version %d\n"
> -			   "address: %s\n"
> -			   "protocol: %s\n"
> -			   "port: %s\n",
> -			   (char *)&server,
> -			   (char *)&service, &program, &version,
> -			   (char *)&address,
> -			   (char *)&protoname,
> -			   (char *)&port);
> +			   "RPC server: %ms\n"
> +			   "service: %ms (%d) version %d\n"
> +			   "address: %ms\n"
> +			   "protocol: %ms\n"
> +			   "port: %ms\n",
> +			   &server,
> +			   &service, &program, &version,
> +			   &address,
> +			   &protoname,
> +			   &port);
>  
>  
>  	switch (numfields) {
>