Return-Path: Received: from mail-dm3nam03on0135.outbound.protection.outlook.com ([104.47.41.135]:12986 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732287AbeGKS2c (ORCPT ); Wed, 11 Jul 2018 14:28:32 -0400 From: Trond Myklebust To: "chuck.lever@oracle.com" CC: "SteveD@RedHat.com" , "libtirpc-devel@lists.sourceforge.net" , "linux-nfs@vger.kernel.org" Subject: Re: [Libtirpc-devel] [PATCH V4] xdrstdio_create buffers do not output encoded values on ppc Date: Wed, 11 Jul 2018 18:19:54 +0000 Message-ID: <1c16109cdc64e1bfa6703ddcfae7cf9968102275.camel@hammerspace.com> References: <20180711152521.8238-1-steved@redhat.com> <0953d758440850222bab04aaf3822b396bd736c6.camel@hammer.space> <760B43CD-1561-414E-B186-DB7974707C0E@oracle.com> In-Reply-To: <760B43CD-1561-414E-B186-DB7974707C0E@oracle.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gV2VkLCAyMDE4LTA3LTExIGF0IDE0OjA2IC0wNDAwLCBDaHVjayBMZXZlciB3cm90ZToNCj4g PiBPbiBKdWwgMTEsIDIwMTgsIGF0IDEyOjM4IFBNLCBUcm9uZCBNeWtsZWJ1c3QgPHRyb25kbXlA aGFtbWVyc3BhY2UuDQo+ID4gY29tPiB3cm90ZToNCj4gPiANCj4gPiBPbiBXZWQsIDIwMTgtMDct MTEgYXQgMTI6MDUgLTA0MDAsIFN0ZXZlIERpY2tzb24gd3JvdGU6DQo+ID4gPiBIZXkgVHJvbmQs DQo+ID4gPiANCj4gPiA+IE9uIDA3LzExLzIwMTggMTE6MjUgQU0sIFN0ZXZlIERpY2tzb24gd3Jv dGU6DQo+ID4gPiA+IFRoZSBjYXVzZSBpcyB0aGF0IHRoZSB4ZHJfcHV0bG9uZyB1c2VzIGEgbG9u ZyB0byBzdG9yZSB0aGUNCj4gPiA+ID4gY29udmVydGVkIHZhbHVlLCB0aGVuIHBhc3NlcyBpdCB0 byBmd3JpdGUgYXMgYSBieXRlIGJ1ZmZlci4NCj4gPiA+ID4gT25seSB0aGUgZmlyc3QgNCBieXRl cyBhcmUgd3JpdHRlbiwgd2hpY2ggaXMgb2theSBmb3IgYSBMRQ0KPiA+ID4gPiBzeXN0ZW0gYWZ0 ZXIgYnl0ZXN3YXBwaW5nLCBidXQgd3JpdGVzIGFsbCB6ZXJvZXMgb24gQkUgc3lzdGVtcy4NCj4g PiA+ID4gDQo+ID4gPiA+IEZpeGVzOiBodHRwczovL2J1Z3ppbGxhLnJlZGhhdC5jb20vc2hvd19i dWcuY2dpP2lkPTEyNjE3MzgNCj4gPiA+ID4gDQo+ID4gPiA+IFJldmlld2VkLWJ5OiBDaHVjayBM ZXZlciA8Y2h1Y2subGV2ZXJAb3JhY2xlLmNvbT4NCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogU3Rl dmUgRGlja3NvbiA8c3RldmVkQHJlZGhhdC5jb20+DQo+ID4gPiA+IC0tLQ0KPiA+ID4gPiB2NDog VXNlIFVJTlQzMl9NQVggaW5zdGVhZCBvZiBJTlQzMl9NQVggaW4gYm91bmRhcnkgY2hlY2suDQo+ ID4gPiANCj4gPiA+IFRhbGtpbmcgd2l0aCBzb21lIG9sZCBjcnVzdHkgdHlwZXMgOy0pIHRoZXkg cG9pbnRlZCBvdXQNCj4gPiA+IHRoYXQgYWxsIHRoZXNlIHJvdXRpbmVzIHVzZSBhIHNpZ25lZCBh cmd1bWVudHMgYW5kDQo+ID4gPiBhbHdheXMgaGF2ZS4uLiBTbyBhZ2FpbiB3aHkgaXMgdXNpbmcg YW4gdW5zaWduZWQgbWF4DQo+ID4gPiB0aGUgcmlnaHQgdGhpbmcgdG8gZG8/IA0KPiA+IA0KPiA+ IEFzIEkgc2FpZCBlYXJsaWVyLCB5b3UgYXJlIGNhc3RpbmcgZnJvbSBhIGxhcmdlciB0eXBlIHRv IGEgc21hbGxlcg0KPiA+IHR5cGUsIGFuZCB5b3Ugd2FudCBpdCB0byB3b3JrIGZvciBib3RoIHNp Z25lZCBhbmQgdW5zaWduZWQgMzItYml0DQo+ID4gdmFsdWVzLiBDb25zaWRlciB0aGlzIGtpbmQg b2YgY29kZToNCj4gPiANCj4gPiAgICAgICAgaW50MzJfdCBmb28gPSAweEZGRkYwMDAwOw0KPiA+ ICAgICAgICByZXQgPSB4ZHJzdGRpb19wdXRsb25nKHhkciwgZm9vKTsNCj4gPiANCj4gPiBTaW5j ZSBmb28gaXMgc2lnbmVkLCB0aGVuIChsb25nKWZvbyBlbmRzIHVwIGdldHRpbmcgY2FzdCB0bw0K PiA+IDB4RkZGRkZGRkZGRkZGMDAwMEwsIHdoaWNoIGlzIG5lZ2F0aXZlLCBidXQgaXMgPiAobG9u ZylJTlQzMl9NSU4uDQo+ID4gU28NCj4gPiByZXQgPT0gVFJVRTsNCj4gDQo+IE9uIDMyLWJpdCBz eXN0ZW1zLCB4ZHJzdGRpb19wdXRsb25nKCkgY2Fubm90IHdvcmsgZm9yIHZhbHVlcw0KPiBiZXR3 ZWVuIElOVDMyX01BWCBhbmQgVUlOVDMyX01BWC4gSXQgc2hvdWxkIHJldHVybiBGQUxTRSBmb3IN Cj4gdGhlc2UgdmFsdWVzIG9uIDY0LWJpdCBzeXN0ZW1zLiBJbiBmYWN0LCB0aGF0IGlzIHRoZSB3 YXkgdGhpcw0KPiBBUEkgYmVoYXZlcyBmb3Igb3RoZXIgNjQtYml0IGF3YXJlIGxpYnRpcnBjIGlt cGxlbWVudGF0aW9ucy4NCg0KT24gYSAzMi1iaXQgc3lzdGVtIHRoZXJlIGlzIG5vIG5lZWQgdG8g Y2hlY2sgYW55dGhpbmcsIGJlY2F1c2UNCnNpemVvZihsb25nKSA9PSBzaXplb2YoaW50KSA9PSA0 Lg0KDQpUaGUgcHJvYmxlbXMgb2NjdXIgb25jZSB5b3Ugc3RhcnQgY2FzdGluZyBmcm9tIGEgc21h bGxlciBzaXplZCBpbnRlZ2VyDQp0byBhIGxhcmdlciBvbmUgYmVjYXVzZSB0aGUgdW5zaWduZWQg Y2FzdCB3aWxsIGJlaGF2ZSBkaWZmZXJlbnRseSB0bw0KdGhlIHNpZ25lZCBjYXN0IGFuZCByZXN1 bHQgaW4gYSBiaXR3aXNlIHZlcnkgZGlmZmVyZW50IHZhbHVlLg0KDQo+ID4gTm93IHRyeToNCj4g PiANCj4gPiAgICAgICAgdWludDMyX3QgYmFyID0gMHhGRkZGMDAwMFU7DQo+ID4gICAgICAgIHJl dCA9IHhkcnN0ZGlvX3B1dGxvbmcoeGRyLCBiYXIpOw0KPiA+IA0KPiA+IA0KPiA+IFNpbmNlIGJh ciBpcyB1bnNpZ25lZCwgdGhlbiAobG9uZyliYXIgZ2V0cyBjYXN0IHRvIDB4RkZGRjAwMDBMLg0K PiA+IFRoYXQgaXMNCj4gPiBjbGVhcmx5ID4gKGxvbmcpSU5UMzJfTUFYID09IDB4N0ZGRkZGRkZM LCBhbmQgc28gdGhlIGFib3ZlIGZhaWxzDQo+ID4gd2l0aA0KPiA+IHJldCA9PSBGQUxTRS4NCj4g PiANCj4gPiANCj4gPiBCVFc6IFRoZSBhYm92ZSBpcyBwcmV0dHkgbXVjaCBleGFjdGx5IGhvdyB4 ZHJfaW50MzJfdCgpIGFuZA0KPiA+IHhkcl91aW50MzJfdCgpIHdvcmsuIFRoZSBmb3JtZXIgZG9l cyBhIHNpZ25lZCBjYXN0IHRvIGxvbmcsIHdoaWxlDQo+ID4gdGhlDQo+ID4gbGF0dGVyIGRvZXMg YW4gdW5zaWduZWQgY2FzdCB0byBsb25nLg0KPiANCj4gSWYgdGhhdCdzIHRoZSBjYXNlLCB3ZSBz aG91bGQgZXhhbWluZSBob3cgb3RoZXIgNjQtYml0IGF3YXJlDQo+IGxpYnRpcnBjIGltcGxlbWVu dGF0aW9ucyB3b3JrIGFuZCBmaXggb3VycyB0byBiZWhhdmUgdGhlIHNhbWUuDQo+IE91ciBsaWJ0 aXJwYyBmb3JrZWQgaW4gdGhlIGxhdGUgMTk5MHMgYmVmb3JlIDY0LWJpdCBzeXN0ZW1zDQo+IHdl cmUgd2lkZWx5IGRlcGxveWVkLCBzbyBJIGhhdmUgc29tZSBkb3VidHMgd2hldGhlciBvdXINCj4g aW1wbGVtZW50YXRpb24gaXMgY29ycmVjdC4NCg0KT2JzZXJ2ZToNCg0KYm9vbF90DQp4ZHJfaW50 MzJfdCh4ZHJzLCBpbnQzMl9wKQ0KICAgICAgICBYRFIgKnhkcnM7DQogICAgICAgIGludDMyX3Qg KmludDMyX3A7DQp7DQogICAgICAgIGxvbmcgbDsNCg0KICAgICAgICBzd2l0Y2ggKHhkcnMtPnhf b3ApIHsNCg0KICAgICAgICBjYXNlIFhEUl9FTkNPREU6DQogICAgICAgICAgICAgICAgbCA9IChs b25nKSAqaW50MzJfcDsNCiAgICAgICAgICAgICAgICByZXR1cm4gKFhEUl9QVVRMT05HKHhkcnMs ICZsKSk7DQoNCiAgICAgICAgY2FzZSBYRFJfREVDT0RFOg0KICAgICAgICAgICAgICAgIGlmICgh WERSX0dFVExPTkcoeGRycywgJmwpKSB7DQogICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4g KEZBTFNFKTsNCiAgICAgICAgICAgICAgICB9DQogICAgICAgICAgICAgICAgKmludDMyX3AgPSAo aW50MzJfdCkgbDsNCiAgICAgICAgICAgICAgICByZXR1cm4gKFRSVUUpOw0KDQogICAgICAgIGNh c2UgWERSX0ZSRUU6DQogICAgICAgICAgICAgICAgcmV0dXJuIChUUlVFKTsNCiAgICAgICAgfQ0K ICAgICAgICAvKiBOT1RSRUFDSEVEICovDQogICAgICAgIHJldHVybiAoRkFMU0UpOw0KfQ0KDQpi b29sX3QNCnhkcl91X2ludDMyX3QoeGRycywgdV9pbnQzMl9wKQ0KICAgICAgICBYRFIgKnhkcnM7 DQogICAgICAgIHVfaW50MzJfdCAqdV9pbnQzMl9wOw0Kew0KICAgICAgICB1X2xvbmcgbDsNCg0K ICAgICAgICBzd2l0Y2ggKHhkcnMtPnhfb3ApIHsNCg0KICAgICAgICBjYXNlIFhEUl9FTkNPREU6 DQogICAgICAgICAgICAgICAgbCA9ICh1X2xvbmcpICp1X2ludDMyX3A7DQogICAgICAgICAgICAg ICAgcmV0dXJuIChYRFJfUFVUTE9ORyh4ZHJzLCAobG9uZyAqKSZsKSk7DQoNCiAgICAgICAgY2Fz ZSBYRFJfREVDT0RFOg0KICAgICAgICAgICAgICAgIGlmICghWERSX0dFVExPTkcoeGRycywgKGxv bmcgKikmbCkpIHsNCiAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAoRkFMU0UpOw0KICAg ICAgICAgICAgICAgIH0NCiAgICAgICAgICAgICAgICAqdV9pbnQzMl9wID0gKHVfaW50MzJfdCkg bDsNCiAgICAgICAgICAgICAgICByZXR1cm4gKFRSVUUpOw0KDQogICAgICAgIGNhc2UgWERSX0ZS RUU6DQogICAgICAgICAgICAgICAgcmV0dXJuIChUUlVFKTsNCiAgICAgICAgfQ0KICAgICAgICAv KiBOT1RSRUFDSEVEICovDQogICAgICAgIHJldHVybiAoRkFMU0UpOw0KfQ0KDQo+ID4gPiBzdGV2 ZWQuDQo+ID4gPiANCj4gPiA+ID4gDQo+ID4gPiA+IHYzOiBSZXdvcmtlZCB0aGUgYm91bmRzIGNo ZWNraW5nDQo+ID4gPiA+IA0KPiA+ID4gPiB2MjogQWRkZWQgYm91bmRzIGNoZWNraW5nDQo+ID4g PiA+ICAgIENoYW5nZWQgZnJvbSB1bnNpZ25lZCB0byBzaWduZWQNCj4gPiA+ID4gDQo+ID4gPiA+ IHNyYy94ZHJfc3RkaW8uYyB8IDE1ICsrKysrKysrKysrKy0tLQ0KPiA+ID4gPiAxIGZpbGUgY2hh bmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkNCj4gPiA+ID4gDQo+ID4gPiA+ IGRpZmYgLS1naXQgYS9zcmMveGRyX3N0ZGlvLmMgYi9zcmMveGRyX3N0ZGlvLmMNCj4gPiA+ID4g aW5kZXggNDQxMDI2Mi4uODQ2YzdiZiAxMDA2NDQNCj4gPiA+ID4gLS0tIGEvc3JjL3hkcl9zdGRp by5jDQo+ID4gPiA+ICsrKyBiL3NyYy94ZHJfc3RkaW8uYw0KPiA+ID4gPiBAQCAtMzgsNiArMzgs NyBAQA0KPiA+ID4gPiAgKi8NCj4gPiA+ID4gDQo+ID4gPiA+ICNpbmNsdWRlIDxzdGRpby5oPg0K PiA+ID4gPiArI2luY2x1ZGUgPHN0ZGludC5oPg0KPiA+ID4gPiANCj4gPiA+ID4gI2luY2x1ZGUg PGFycGEvaW5ldC5oPg0KPiA+ID4gPiAjaW5jbHVkZSA8cnBjL3R5cGVzLmg+DQo+ID4gPiA+IEBA IC0xMDMsMTAgKzEwNCwxMiBAQCB4ZHJzdGRpb19nZXRsb25nKHhkcnMsIGxwKQ0KPiA+ID4gPiAJ WERSICp4ZHJzOw0KPiA+ID4gPiAJbG9uZyAqbHA7DQo+ID4gPiA+IHsNCj4gPiA+ID4gKwlpbnQz Ml90IG15Y29weTsNCj4gPiA+ID4gDQo+ID4gPiA+IC0JaWYgKGZyZWFkKGxwLCBzaXplb2YoaW50 MzJfdCksIDEsIChGSUxFICopeGRycy0NCj4gPiA+ID4gPnhfcHJpdmF0ZSkgDQo+ID4gPiA+ICE9 IDEpDQo+ID4gPiA+ICsJaWYgKGZyZWFkKCZteWNvcHksIHNpemVvZihpbnQzMl90KSwgMSwgKEZJ TEUgKil4ZHJzLQ0KPiA+ID4gPiA+IHhfcHJpdmF0ZSkgIT0gMSkNCj4gPiA+ID4gDQo+ID4gPiA+ IAkJcmV0dXJuIChGQUxTRSk7DQo+ID4gPiA+IC0JKmxwID0gKGxvbmcpbnRvaGwoKHVfaW50MzJf dCkqbHApOw0KPiA+ID4gPiArDQo+ID4gPiA+ICsJKmxwID0gKGxvbmcpbnRvaGwobXljb3B5KTsN Cj4gPiA+ID4gCXJldHVybiAoVFJVRSk7DQo+ID4gPiA+IH0NCj4gPiA+ID4gDQo+ID4gPiA+IEBA IC0xMTUsOCArMTE4LDE0IEBAIHhkcnN0ZGlvX3B1dGxvbmcoeGRycywgbHApDQo+ID4gPiA+IAlY RFIgKnhkcnM7DQo+ID4gPiA+IAljb25zdCBsb25nICpscDsNCj4gPiA+ID4gew0KPiA+ID4gPiAt CWxvbmcgbXljb3B5ID0gKGxvbmcpaHRvbmwoKHVfaW50MzJfdCkqbHApOw0KPiA+ID4gPiArCWlu dDMyX3QgbXljb3B5Ow0KPiA+ID4gPiArDQo+ID4gPiA+ICsjaWYgZGVmaW5lZChfTFA2NCkNCj4g PiA+ID4gKwlpZiAoKCpscCA+IFVJTlQzMl9NQVgpIHx8ICgqbHAgPCBJTlQzMl9NSU4pKQ0KPiA+ ID4gPiArCQlyZXR1cm4gKEZBTFNFKTsNCj4gPiA+ID4gKyNlbmRpZg0KPiA+ID4gPiANCj4gPiA+ ID4gKwlteWNvcHkgPSAoaW50MzJfdClodG9ubCgoaW50MzJfdCkqbHApOw0KPiA+ID4gPiAJaWYg KGZ3cml0ZSgmbXljb3B5LCBzaXplb2YoaW50MzJfdCksIDEsIChGSUxFICopeGRycy0NCj4gPiA+ ID4gPiB4X3ByaXZhdGUpICE9IDEpDQo+ID4gPiA+IA0KPiA+ID4gPiAJCXJldHVybiAoRkFMU0Up Ow0KPiA+ID4gPiAJcmV0dXJuIChUUlVFKTsNCj4gPiA+ID4gDQo+ID4gPiANCj4gPiA+IC0tDQo+ ID4gPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJz Y3JpYmUgbGludXgtDQo+ID4gPiBuZnMiDQo+ID4gPiBpbg0KPiA+ID4gdGhlIGJvZHkgb2YgYSBt ZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcNCj4gPiA+IE1vcmUgbWFqb3Jkb21v IGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtDQo+ID4g PiBsDQo+ID4gDQo+ID4gLS0gDQo+ID4gVHJvbmQgTXlrbGVidXN0DQo+ID4gTGludXggTkZTIGNs aWVudCBtYWludGFpbmVyLCBIYW1tZXJzcGFjZQ0KPiA+IHRyb25kLm15a2xlYnVzdEBoYW1tZXJz cGFjZS5jb20NCj4gPiANCj4gPiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+IC0tLS0tLS0tLS0tLS0NCj4gPiBDaGVj ayBvdXQgdGhlIHZpYnJhbnQgdGVjaCBjb21tdW5pdHkgb24gb25lIG9mIHRoZSB3b3JsZCdzIG1v c3QNCj4gPiBlbmdhZ2luZyB0ZWNoIHNpdGVzLCBTbGFzaGRvdC5vcmchIGh0dHA6Ly9zZG0ubGlu ay9zbGFzaGRvdA0KPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fDQo+ID4gTGlidGlycGMtZGV2ZWwgbWFpbGluZyBsaXN0DQo+ID4gTGlidGlycGMtZGV2 ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0DQo+ID4gaHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5u ZXQvbGlzdHMvbGlzdGluZm8vbGlidGlycGMtZGV2ZWwNCj4gDQo+IC0tDQo+IENodWNrIExldmVy DQo+IA0KPiANCj4gDQotLSANClRyb25kIE15a2xlYnVzdA0KQ1RPLCBIYW1tZXJzcGFjZSBJbmMN CjQzMDAgRWwgQ2FtaW5vIFJlYWwsIFN1aXRlIDEwNQ0KTG9zIEFsdG9zLCBDQSA5NDAyMg0Kd3d3 LmhhbW1lci5zcGFjZQ0KDQo=