Return-Path: Received: from mx2.suse.de ([195.135.220.15]:33190 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2389553AbeHARp4 (ORCPT ); Wed, 1 Aug 2018 13:45:56 -0400 Date: Wed, 1 Aug 2018 15:59:31 +0000 From: Mark Fasheh To: Amir Goldstein Cc: Al Viro , linux-fsdevel , Linux Btrfs , Andrew Morton , overlayfs , Jeff Mahoney , Linux NFS Mailing List Subject: Re: [PATCH 1/4] vfs: introduce function to map unique ino/dev pairs Message-ID: <20180801155931.GC20761@wotan.suse.de> Reply-To: Mark Fasheh References: <20180731211045.5671-1-mfasheh@suse.de> <20180731211045.5671-2-mfasheh@suse.de> <20180731232127.GB20761@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: Hi Amir, On Wed, Aug 01, 2018 at 08:41:14AM +0300, Amir Goldstein wrote: > > +void vfs_map_unique_ino_dev(struct dentry *dentry, u64 *ino, dev_t *dev) > > I find this function name a bit more than function can guaranty. > It's just a fancy wrapper around ->getattr() > How about vfs_get_ino_dev() ? Yeah I agree with that. An early version actually had the name vfs_get_ino_dev(), I don't mind going back to it. Thanks for the review! --Mark