Return-Path: Received: from szxga06-in.huawei.com ([45.249.212.32]:41709 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725954AbeHBHXx (ORCPT ); Thu, 2 Aug 2018 03:23:53 -0400 From: Wei Yongjun To: Trond Myklebust , Anna Schumaker CC: Wei Yongjun , , Subject: [PATCH -next] NFSv4: Fix error handling in nfs4_sp4_select_mode() Date: Thu, 2 Aug 2018 05:42:04 +0000 Message-ID: <1533188524-152221-1-git-send-email-weiyongjun1@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: Error code is set in the error handling cases but never used. Fix it. Fixes: 937e3133cd0b ("NFSv4.1: Ensure we clear the SP4_MACH_CRED flags in nfs4_sp4_select_mode()") Signed-off-by: Wei Yongjun --- fs/nfs/nfs4proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index c571ee4..8ae1b8d 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -7785,7 +7785,7 @@ static int nfs4_sp4_select_mode(struct nfs_client *clp, } out: clp->cl_sp4_flags = flags; - return 0; + return ret; } struct nfs41_exchange_id_data {