DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A13902080C
MIME-Version: 1.0
References: <20181119153707.10832.42881.stgit@manet.1015granger.net>
 <20181119154607.10832.92558.stgit@manet.1015granger.net> <CAN-5tyG26W+TjTsjpTVvF3RJOGCnD8L79dCbRqKTm5F1V3fuxw@mail.gmail.com>
 <6592845E-0136-4D42-8426-3E2A0BB5FFE7@oracle.com> <CAN-5tyEw5iRaA6mCp5DeNv1DMkFGAqtvq1PcRSiFZ6PQyJpDUA@mail.gmail.com>
 <4A94F1A9-96A4-4A2F-8617-AF0E2380D0C1@oracle.com> <CAN-5tyGU85PJe4Uoocw5NkT8YiYSF8wTWTgg4HycAgKpyHSfiw@mail.gmail.com>
 <9BD3F7C9-96BF-4555-A901-5E82E2CF9E28@oracle.com>
In-Reply-To: <9BD3F7C9-96BF-4555-A901-5E82E2CF9E28@oracle.com>
From:   Olga Kornievskaia <aglo@umich.edu>
Date:   Mon, 19 Nov 2018 16:22:31 -0500
Message-ID: <CAN-5tyELSi-Vtf1W3CSFzynbgVW7rcyJnfHmcb6Ehs0NEUiy4A@mail.gmail.com>
Subject: Re: [PATCH v1 4/4] xprtrdma: Plant XID in on-the-wire RDMA offset (FRWR)
To:     Chuck Lever <chuck.lever@oracle.com>
Cc:     linux-rdma <linux-rdma@vger.kernel.org>,
        linux-nfs <linux-nfs@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 19, 2018 at 1:59 PM Chuck Lever <chuck.lever@oracle.com> wrote:
>
>
>
> > On Nov 19, 2018, at 1:47 PM, Olga Kornievskaia <aglo@umich.edu> wrote:
> >
> > On Mon, Nov 19, 2018 at 1:19 PM Chuck Lever <chuck.lever@oracle.com> wrote:
> >>
> >>
> >>
> >>> On Nov 19, 2018, at 1:08 PM, Olga Kornievskaia <aglo@umich.edu> wrote:
> >>>
> >>> On Mon, Nov 19, 2018 at 12:59 PM Chuck Lever <chuck.lever@oracle.com> wrote:
> >>>>
> >>>>
> >>>>
> >>>>> On Nov 19, 2018, at 12:47 PM, Olga Kornievskaia <aglo@umich.edu> wrote:
> >>>>>
> >>>>> On Mon, Nov 19, 2018 at 10:46 AM Chuck Lever <chuck.lever@oracle.com> wrote:
> >>>>>>
> >>>>>> Place the associated RPC transaction's XID in the upper 32 bits of
> >>>>>> each RDMA segment's rdma_offset field. These bits are currently
> >>>>>> always zero.
> >>>>>>
> >>>>>> There are two reasons to do this:
> >>>>>>
> >>>>>> - The R_key only has 8 bits that are different from registration to
> >>>>>> registration. The XID adds more uniqueness to each RDMA segment to
> >>>>>> reduce the likelihood of a software bug on the server reading from
> >>>>>> or writing into memory it's not supposed to.
> >>>>>>
> >>>>>> - On-the-wire RDMA Read and Write operations do not otherwise carry
> >>>>>> any identifier that matches them up to an RPC. The XID in the
> >>>>>> upper 32 bits will act as an eye-catcher in network captures.
> >>>>>
> >>>>> Is this just an "eye-catcher" or do you have plans to use it in
> >>>>> wireshark? If the latter, then can we really do that? while a linux
> >>>>> implementation may do that, other (or even possibly future linux)
> >>>>> implementation might not do this. Can we justify changing the
> >>>>> wireshark logic for it?
> >>>>
> >>>> No plans to change the wireshark RPC-over-RDMA dissector.
> >>>> That would only be a valid thing to do if adding the XID
> >>>> were made part of the RPC-over-RDMA protocol via an RFC.
> >>>
> >>> Agreed. Can you also help me understand the proposal (as I'm still
> >>> trying to figure why it is useful).
> >>>
> >>> You are proposing to modify the RDMA segments's RDMA offset field (I
> >>> see top 6bits are indeed always 0). I don't see how adding that helps
> >>> an RDMA read/write message which does not have an "offset" field in it
> >>> be matched to a particular RPC. I don't believe we have (had) any
> >>> issues matching the initial RC Send only that contains the RDMA_MSG to
> >>> the RPC.
> >>
> >> The ULP has access to only the low order 8 bits of the R_key. The
> >> upper 24 bits are fixed for each MR. So for any given MR, there are
> >> only 256 unique R_key values. That means the same R_key will appear
> >> again quickly on the wire.
> >>
> >> The 64-bit offset field is set by the ULP, and can be essentially
> >> any arbitrary value. Most kernel ULPs use the iova of the registered
> >> memory. We only need the lower 32 bits for that.
> >>
> >> The purpose of adding junk to the offset is to make the offset
> >> unique to that RPC transaction, just like the R_key is. This helps
> >> make the RDMA segment co-ordinates (handle, length, offset) more
> >> unique and thus harder to spoof.
> >
> > Thank you for the explanation that makes sense.
> >
> >> We could use random numbers in that upper 32 bits, but we have
> >> something more handy: the RPC's XID.
> >>
> >> Now when you look at an RDMA Read or Write, the top 32 bits in each
> >> RDMA segment's offset match the XID of the RPC transaction that the
> >> RDMA operations go with. This is really a secondary benefit to the
> >> uniquifying effect above.
> >
> > I find the wording "no the wire RDMA read or write" misleading. Did
> > you really mean it as "RDMA read or write" or do you mean "RDMA_MSG"
> > or do you mean "NFS RDMA read or write"? Because RDMA offset is not a
> > part of the RDMA read/write (first/middle/last) packet. That's what
> > I'm hanged up on.
>
> Here's an RDMA Read request in a network capture I had at hand:
>
> No.     Time               Source                Destination           Protocol Length Info
>     228 22:31:06.203637    LID: 5                LID: 11               InfiniBand 42     RC RDMA Read Request QP=0x000240
>
> Frame 228: 42 bytes on wire (336 bits), 42 bytes captured (336 bits) on interface 1
> Extensible Record Format
> InfiniBand
>     Local Route Header
>     Base Transport Header
>     RETH - RDMA Extended Transport Header
>         Virtual Address: 11104011393315758080   <<<<<<
>         Remote Key: 1879114618
>         DMA Length: 4015
>     Invariant CRC: 0xd492a3e1
>     Variant CRC: 0x8736
>
> The value of the Virtual Address field is what the RPC-over-RDMA
> protocol calls the Offset. The Read responses are matched to this
> request by their message sequence numbers, and this Read request is
> matched to the RPC Call by the XID in the top 32 bits of the
> Virtual Address.
>
> Likewise for an RDMA Write Only request:
>
>     188 22:31:06.201350    LID: 5                LID: 11               InfiniBand 162    RC RDMA Write Only QP=0x000240
>
> Frame 188: 162 bytes on wire (1296 bits), 162 bytes captured (1296 bits) on interface 1
> Extensible Record Format
> InfiniBand
>     Local Route Header
>     Base Transport Header
>     RETH - RDMA Extended Transport Header
>         Virtual Address: 10455493047213809920   <<<<<<
>         Remote Key: 1879115386
>         DMA Length: 120
>     Invariant CRC: 0xe2e1b2cd
>     Variant CRC: 0x676f
> Data (120 bytes)
>
> 0000  91 19 5f 87 00 00 00 01 00 00 00 00 00 00 00 00   .._.............
> 0010  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01   ................
> 0020  00 00 00 02 00 00 01 ed 00 00 00 02 00 00 04 16   ................
> 0030  00 00 00 64 00 00 00 00 00 00 00 28 00 00 00 00   ...d.......(....
> 0040  00 00 00 00 00 00 00 00 00 00 00 00 54 9e e5 9d   ............T...
> 0050  c6 d3 1a d2 00 00 00 00 00 00 63 1f 5b f2 2e 7a   ..........c.[..z
> 0060  0b ae f9 ec 5b f2 2e 7a 0b 53 6c ef 5b f2 2e 7a   ....[..z.Sl.[..z
> 0070  0b 53 6c ef 00 00 00 0c                           .Sl.....
>
>
> I believe RDMA Write First also has an RETH. The sender does not
> interleave RDMA Writes, so subsequent Middle and Last packets go
> with this RDMA Write First.

Ok I see now where I was confused, in RDMA_MSG in the wireshark it's
labeled "RDMA offset" and the in the RDMA write first message it's
labeled "Virtual address". Thank you for explanation.

Here's the next question (coming from Jorge)? Is it reasonable to
assume that top 32bits are always zero? I have an network trace (from
4.18-rc2 kernel) where they are not.

RPC over RDMA
    XID: 0xa347cfa2
    Version: 1
    Flow Control: 128
    Message Type: RDMA_MSG (0)
    Read list (count: 0)
    Write list (count: 1)
        Write chunk (1 segment)
            Write chunk segment count: 1
            RDMA segment 0
                RDMA handle: 0x4000076f
                RDMA length: 65676
                RDMA offset: 0x0000001049973000

I don't believe 0xa347cfa2 can fit?
>
>
> --
> Chuck Lever
>
>
>