DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 975FF21019
Subject: Re: [PATCH] [nfs-utils] mount: improve error msg when mount fail wirh
 EBUSY
To:     "Jianhong.Yin" <yin-jianhong@163.com>
Cc:     linux-nfs@vger.kernel.org
References: <20181025045400.24997-1-yin-jianhong@163.com>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <77fe8d1f-412e-e3d6-1f93-c0c63cfbec00@RedHat.com>
Date:   Thu, 29 Nov 2018 14:49:36 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.1
MIME-Version: 1.0
In-Reply-To: <20181025045400.24997-1-yin-jianhong@163.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 10/25/18 12:54 AM, Jianhong.Yin wrote:
> EBUSY can happen when mounting a filesystem that
> is already mounted or when the context= are
> different when using the -o sharecache
> 
> so update the error message from to:
> - %mountpoint% is busy or already mounted
> + %mountpoint% is busy or already mounted or sharecache fail
> 
> Signed-off-by: Jianhong Yin <yin-jianhong@163.com>
Committed.... 

steved.

> ---
>  utils/mount/error.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/mount/error.c b/utils/mount/error.c
> index c9797fc..dfe5c7d 100644
> --- a/utils/mount/error.c
> +++ b/utils/mount/error.c
> @@ -223,7 +223,7 @@ void mount_error(const char *spec, const char *mount_point, int error)
>  				  progname, mount_point);
>  		break;
>  	case EBUSY:
> -		nfs_error(_("%s: %s is busy or already mounted"),
> +		nfs_error(_("%s: %s is busy or already mounted or sharecache fail"),
>  			progname, mount_point);
>  		break;
>  	case ENOENT:
> -- 2.17.2
>