DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39DC52084C
Subject: Re: [PATCH] nfsref: switch the way libraries are linked.
To:     Chuck Lever <chuck.lever@oracle.com>
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
References: <20181211190944.71940-1-steved@redhat.com>
 <0F088877-F56A-47FF-BBF3-95A8293BF912@oracle.com>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <40177ab7-bf23-7966-fbfa-9bac12d4655c@RedHat.com>
Date:   Tue, 11 Dec 2018 17:27:22 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.1
MIME-Version: 1.0
In-Reply-To: <0F088877-F56A-47FF-BBF3-95A8293BF912@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 12/11/18 2:12 PM, Chuck Lever wrote:
> 
>> On Dec 11, 2018, at 2:09 PM, Steve Dickson <steved@redhat.com> wrote:
>>
>> Link the static libs before the dynamic libs allowing
>> the routines in the static libs to be defined
>> by the dynamic libs
> 
> Hi Steve, Why is this change necessary? Is there a bug report?
No... when I enabled junctions in the Fedora rawhide (F30) I got
a bunch of xml undefined routines 
   https://koji.fedoraproject.org/koji/getfile?taskID=31408933&volume=DEFAULT&name=build.log&offset=-4000

It compiled fine on f29 but not on rawhide

After asking if the XML api changed, people suggested I simply
change the order of how the static and dynamic libs are linked,
which worked

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6UIAF47S73QFLCJDWEWXKQHZTOMB5JXQ/

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/VK2XPHV2MELV6IRKBG2ITI6GKUBMMRQW/

steved.

> 
> 
>> Signed-off-by: Steve Dickson <steved@redhat.com>
>> ---
>> utils/nfsref/Makefile.am | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/utils/nfsref/Makefile.am b/utils/nfsref/Makefile.am
>> index 44edc83..2409dd0 100644
>> --- a/utils/nfsref/Makefile.am
>> +++ b/utils/nfsref/Makefile.am
>> @@ -27,9 +27,9 @@ noinst_HEADERS		= nfsref.h
>>
>> sbin_PROGRAMS		= nfsref
>> nfsref_SOURCES		= add.c lookup.c nfsref.c remove.c
>> -LDADD			= $(LIBXML2) $(LIBCAP) \
>> -			  ../../support/nfs/libnfs.la \
>> -			  ../../support/junction/libjunction.la
>> +LDADD			= ../../support/nfs/libnfs.la \
>> +			  ../../support/junction/libjunction.la \
>> +			  $(LIBXML2) $(LIBCAP)
>>
>> man8_MANS		= nfsref.man
>>
>> -- 
>> 2.19.2
>>
> 
> --
> Chuck Lever
> 
> 
>