DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F23EB2084E
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Re: [PATCH] nfsref: switch the way libraries are linked.
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <40177ab7-bf23-7966-fbfa-9bac12d4655c@RedHat.com>
Date:   Wed, 12 Dec 2018 10:54:29 -0500
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <BEDC3A34-5C04-4AF9-852B-B8BD104A4BA4@oracle.com>
References: <20181211190944.71940-1-steved@redhat.com>
 <0F088877-F56A-47FF-BBF3-95A8293BF912@oracle.com>
 <40177ab7-bf23-7966-fbfa-9bac12d4655c@RedHat.com>
To:     Steve Dickson <SteveD@redhat.com>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Dec 11, 2018, at 5:27 PM, Steve Dickson <SteveD@redhat.com> wrote:
>=20
>=20
>=20
> On 12/11/18 2:12 PM, Chuck Lever wrote:
>>=20
>>> On Dec 11, 2018, at 2:09 PM, Steve Dickson <steved@redhat.com> =
wrote:
>>>=20
>>> Link the static libs before the dynamic libs allowing
>>> the routines in the static libs to be defined
>>> by the dynamic libs
>>=20
>> Hi Steve, Why is this change necessary? Is there a bug report?
> No... when I enabled junctions in the Fedora rawhide (F30) I got
> a bunch of xml undefined routines=20
>   =
https://koji.fedoraproject.org/koji/getfile?taskID=3D31408933&volume=3DDEF=
AULT&name=3Dbuild.log&offset=3D-4000
>=20
> It compiled fine on f29 but not on rawhide
>=20
> After asking if the XML api changed, people suggested I simply
> change the order of how the static and dynamic libs are linked,
> which worked
>=20
> =
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.or=
g/message/6UIAF47S73QFLCJDWEWXKQHZTOMB5JXQ/
>=20
> =
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.or=
g/message/VK2XPHV2MELV6IRKBG2ITI6GKUBMMRQW/

OK. See also:

=
http://git.linux-nfs.org/?p=3Dcel/fedfs-utils.git;a=3Dcommit;h=3D05d645002=
3265e15bdc6e6bd24c05b1586e87d1d

which is a similar change, but it hits other Makefiles as well.
I wonder why only nfsref/Makefile.am is affected for you.


> steved.
>=20
>>=20
>>=20
>>> Signed-off-by: Steve Dickson <steved@redhat.com>
>>> ---
>>> utils/nfsref/Makefile.am | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>=20
>>> diff --git a/utils/nfsref/Makefile.am b/utils/nfsref/Makefile.am
>>> index 44edc83..2409dd0 100644
>>> --- a/utils/nfsref/Makefile.am
>>> +++ b/utils/nfsref/Makefile.am
>>> @@ -27,9 +27,9 @@ noinst_HEADERS		=3D nfsref.h
>>>=20
>>> sbin_PROGRAMS		=3D nfsref
>>> nfsref_SOURCES		=3D add.c lookup.c nfsref.c remove.c
>>> -LDADD			=3D $(LIBXML2) $(LIBCAP) \
>>> -			  ../../support/nfs/libnfs.la \
>>> -			  ../../support/junction/libjunction.la
>>> +LDADD			=3D ../../support/nfs/libnfs.la \
>>> +			  ../../support/junction/libjunction.la \
>>> +			  $(LIBXML2) $(LIBCAP)
>>>=20
>>> man8_MANS		=3D nfsref.man
>>>=20
>>> --=20
>>> 2.19.2
>>>=20
>>=20
>> --
>> Chuck Lever
>>=20
>>=20
>>=20

--
Chuck Lever