DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE7052080F
Subject: Re: [PATCH] nfsref: switch the way libraries are linked.
To:     Chuck Lever <chuck.lever@oracle.com>
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
References: <20181211190944.71940-1-steved@redhat.com>
 <0F088877-F56A-47FF-BBF3-95A8293BF912@oracle.com>
 <40177ab7-bf23-7966-fbfa-9bac12d4655c@RedHat.com>
 <BEDC3A34-5C04-4AF9-852B-B8BD104A4BA4@oracle.com>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <1e5b3bba-2992-1cfb-a3b3-df24e4587369@RedHat.com>
Date:   Wed, 12 Dec 2018 11:17:57 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.1
MIME-Version: 1.0
In-Reply-To: <BEDC3A34-5C04-4AF9-852B-B8BD104A4BA4@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 12/12/18 10:54 AM, Chuck Lever wrote:
> 
> 
>> On Dec 11, 2018, at 5:27 PM, Steve Dickson <SteveD@redhat.com> wrote:
>>
>>
>>
>> On 12/11/18 2:12 PM, Chuck Lever wrote:
>>>
>>>> On Dec 11, 2018, at 2:09 PM, Steve Dickson <steved@redhat.com> wrote:
>>>>
>>>> Link the static libs before the dynamic libs allowing
>>>> the routines in the static libs to be defined
>>>> by the dynamic libs
>>>
>>> Hi Steve, Why is this change necessary? Is there a bug report?
>> No... when I enabled junctions in the Fedora rawhide (F30) I got
>> a bunch of xml undefined routines 
>>   https://koji.fedoraproject.org/koji/getfile?taskID=31408933&volume=DEFAULT&name=build.log&offset=-4000
>>
>> It compiled fine on f29 but not on rawhide
>>
>> After asking if the XML api changed, people suggested I simply
>> change the order of how the static and dynamic libs are linked,
>> which worked
>>
>> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6UIAF47S73QFLCJDWEWXKQHZTOMB5JXQ/
>>
>> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/VK2XPHV2MELV6IRKBG2ITI6GKUBMMRQW/
> 
> OK. See also:
> 
> http://git.linux-nfs.org/?p=cel/fedfs-utils.git;a=commit;h=05d6450023265e15bdc6e6bd24c05b1586e87d1d
> 
> which is a similar change, but it hits other Makefiles as well.
> I wonder why only nfsref/Makefile.am is affected for you.
Well taking a quick look at the utils/*/Makefile.am files,
in general with two exceptions, the static libs are always defined 
be for the dynamic libs... 

And why it compiled on Fedora 29 and not Fedora 30 (rawhide)...
Well... I have no idea... its going down as one of those 
the gcc/ld mysteries ;-) 

Committed!

steved.

> 
> 
>> steved.
>>
>>>
>>>
>>>> Signed-off-by: Steve Dickson <steved@redhat.com>
>>>> ---
>>>> utils/nfsref/Makefile.am | 6 +++---
>>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/utils/nfsref/Makefile.am b/utils/nfsref/Makefile.am
>>>> index 44edc83..2409dd0 100644
>>>> --- a/utils/nfsref/Makefile.am
>>>> +++ b/utils/nfsref/Makefile.am
>>>> @@ -27,9 +27,9 @@ noinst_HEADERS		= nfsref.h
>>>>
>>>> sbin_PROGRAMS		= nfsref
>>>> nfsref_SOURCES		= add.c lookup.c nfsref.c remove.c
>>>> -LDADD			= $(LIBXML2) $(LIBCAP) \
>>>> -			  ../../support/nfs/libnfs.la \
>>>> -			  ../../support/junction/libjunction.la
>>>> +LDADD			= ../../support/nfs/libnfs.la \
>>>> +			  ../../support/junction/libjunction.la \
>>>> +			  $(LIBXML2) $(LIBCAP)
>>>>
>>>> man8_MANS		= nfsref.man
>>>>
>>>> -- 
>>>> 2.19.2
>>>>
>>>
>>> --
>>> Chuck Lever
>>>
>>>
>>>
> 
> --
> Chuck Lever
> 
> 
>