Date:   Fri, 14 Dec 2018 09:45:33 -0500
To:     Olga Kornievskaia <olga.kornievskaia@gmail.com>
Cc:     bfields@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] NFSD remove OP_CACHEME from 4.2 op_flags
Message-ID: <20181214144533.GA8696@fieldses.org>
References: <20181204190921.61662-1-olga.kornievskaia@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181204190921.61662-1-olga.kornievskaia@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
From:   bfields@fieldses.org (J. Bruce Fields)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

Thanks, applying for 4.21.--b.

On Tue, Dec 04, 2018 at 02:09:21PM -0500, Olga Kornievskaia wrote:
> From: Olga Kornievskaia <kolga@netapp.com>
> 
> OP_CACHEME is only for the 4.0 operations.
> 
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> ---
>  fs/nfsd/nfs4proc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index 238c4b7..60c4650 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -3010,25 +3010,25 @@ static inline u32 nfsd4_seek_rsize(struct svc_rqst *rqstp, struct nfsd4_op *op)
>  	/* NFSv4.2 operations */
>  	[OP_ALLOCATE] = {
>  		.op_func = nfsd4_allocate,
> -		.op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
> +		.op_flags = OP_MODIFIES_SOMETHING,
>  		.op_name = "OP_ALLOCATE",
>  		.op_rsize_bop = nfsd4_only_status_rsize,
>  	},
>  	[OP_DEALLOCATE] = {
>  		.op_func = nfsd4_deallocate,
> -		.op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
> +		.op_flags = OP_MODIFIES_SOMETHING,
>  		.op_name = "OP_DEALLOCATE",
>  		.op_rsize_bop = nfsd4_only_status_rsize,
>  	},
>  	[OP_CLONE] = {
>  		.op_func = nfsd4_clone,
> -		.op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
> +		.op_flags = OP_MODIFIES_SOMETHING,
>  		.op_name = "OP_CLONE",
>  		.op_rsize_bop = nfsd4_only_status_rsize,
>  	},
>  	[OP_COPY] = {
>  		.op_func = nfsd4_copy,
> -		.op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
> +		.op_flags = OP_MODIFIES_SOMETHING,
>  		.op_name = "OP_COPY",
>  		.op_rsize_bop = nfsd4_copy_rsize,
>  	},
> -- 
> 1.8.3.1