Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Re: [PATCH v2 1/3] SUNRPC: Fix disconnection races
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <b4b3eeb9ed30437998c9cc7766012ff0fd316b8e.camel@hammerspace.com>
Date:   Tue, 18 Dec 2018 12:27:53 -0500
Cc:     "smayhew@redhat.com" <smayhew@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "dwysocha@redhat.com" <dwysocha@redhat.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <68DFAB69-180B-4B78-B4F3-EB7DD7B8152C@oracle.com>
References: <20181217225235.124448-1-trond.myklebust@hammerspace.com>
 <20181218142055.GK27213@coeurl.usersys.redhat.com>
 <2acfb506b55380b3c46ef62cd597d724a517fd75.camel@hammerspace.com>
 <5499D539-B24A-4E54-B9A7-11A91ADE9C0B@oracle.com>
 <b4b3eeb9ed30437998c9cc7766012ff0fd316b8e.camel@hammerspace.com>
To:     Trond Myklebust <trondmy@hammerspace.com>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Dec 18, 2018, at 11:02 AM, Trond Myklebust =
<trondmy@hammerspace.com> wrote:
>=20
> On Tue, 2018-12-18 at 10:59 -0500, Chuck Lever wrote:
>>> On Dec 18, 2018, at 10:55 AM, Trond Myklebust <
>>> trondmy@hammerspace.com> wrote:
>>>=20
>>> On Tue, 2018-12-18 at 09:20 -0500, Scott Mayhew wrote:
>>>> I ran Dave's test in a loop over night with these 3 patches on
>>>> top of
>>>> v4.20-rc7 and didn't see any more of the XPRT_WRITE_SPACE hangs.
>>>>=20
>>>=20
>>> Thanks for verifying that!
>>=20
>> With these three patches and my RDMA-related disconnect fixes, fio8
>> on krb5i
>> now works fine, even though the connect count was 508. No stalls or
>> deadlocks.
>>=20
>> Tested-by: Chuck Lever <chuck.lever@oracle.com>
>=20
> Yay! Thanks Chuck.

I am highly in favor of fewer thundering herd wake-ups !  ;-)


--
Chuck Lever