Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B856C43387 for ; Tue, 18 Dec 2018 20:03:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53D302184C for ; Tue, 18 Dec 2018 20:03:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726810AbeLRUDA (ORCPT ); Tue, 18 Dec 2018 15:03:00 -0500 Received: from relay.sw.ru ([185.231.240.75]:50456 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726451AbeLRUDA (ORCPT ); Tue, 18 Dec 2018 15:03:00 -0500 Received: from [172.16.24.21] by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1gZLZn-00026H-Q4; Tue, 18 Dec 2018 23:02:47 +0300 Subject: Re: [PATCH 1/4] nfs: use-after-free in svc_process_common() To: Trond Myklebust , "bfields@fieldses.org" Cc: "anna.schumaker@netapp.com" , "khorenko@virtuozzo.com" , "linux-nfs@vger.kernel.org" , "eshatokhin@virtuozzo.com" , "chuck.lever@oracle.com" , "jlayton@kernel.org" References: <134cf19c-e698-abed-02de-1659f9a5d4fb@virtuozzo.com> <20181217215026.GA8564@fieldses.org> <67f477b704d34b369f0530891a219f383f964001.camel@hammerspace.com> <4d878140-02c0-e306-fee6-1573d9fdecf2@virtuozzo.com> <068f1741afc54367853a2e4501fd95c2ab12a989.camel@hammerspace.com> From: Vasily Averin Message-ID: Date: Tue, 18 Dec 2018 23:02:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <068f1741afc54367853a2e4501fd95c2ab12a989.camel@hammerspace.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 12/18/18 5:55 PM, Trond Myklebust wrote: >>> It probably also requires us to store a pointer to struct net in >>> the >>> struct svc_rqst so that nfs4_callback_compound() and >>> svcauth_gss_accept() can find it, but that should be OK since the >>> transport already has that referenced. Ok, I can fix these functions and their sub-calls. However rqst->rq_xprt is used in other functions that seems can be called inside svc_process_common() - in trace_svc_process(rqstp, progp->pg_name); - in svc_reserve_auth(rqstp, ...) -> svc_reserve() - svc_authorise() -> svcauth_gss_release() It seems I should fix these places too, it isn't? could you please advise how to fix svc_reserve() ?