Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Re: [PATCH v2] xprtrdma: Make sure Send CQ is allocated on an
 existing compvec
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <164839c0-399e-d01b-dafc-5c873e650bdb@suse.com>
Date:   Fri, 25 Jan 2019 09:32:01 -0800
Cc:     linux-rdma@vger.kernel.org,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <F7BDA38C-7ACB-4A10-972B-628E59EE64EA@oracle.com>
References: <164839c0-399e-d01b-dafc-5c873e650bdb@suse.com>
To:     Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Jan 23, 2019, at 11:02 PM, Nicolas Morey-Chaisemartin =
<nmoreychaisemartin@suse.com> wrote:
>=20
> Make sure the device has at least 2 completion vectors before =
allocating to compvec#1
>=20
> Fixes: a4699f5647f3 (xprtrdma: Put Send CQ in IB_POLL_WORKQUEUE mode)
> Signed-off-by: Nicolas Morey-Chaisemartin =
<nmoreychaisemartin@suse.com>
> ---
> Fixes since v1:
> - Use num_comp_vector instead online_cpus
>=20
> net/sunrpc/xprtrdma/verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
> index b725911c0f3f..db913bcef984 100644
> --- a/net/sunrpc/xprtrdma/verbs.c
> +++ b/net/sunrpc/xprtrdma/verbs.c
> @@ -546,7 +546,7 @@ rpcrdma_ep_create(struct rpcrdma_ep *ep, struct =
rpcrdma_ia *ia,
>=20
> 	sendcq =3D ib_alloc_cq(ia->ri_device, NULL,
> 			     ep->rep_attr.cap.max_send_wr + 1,
> -			     1, IB_POLL_WORKQUEUE);
> +			     ia->ri_device->num_comp_vectors > 1 ? 1 : =
0, IB_POLL_WORKQUEUE);

Nit: You should split this line. Otherwise:

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

And I'll look into smarter compvec allocation again.


> 	if (IS_ERR(sendcq)) {
> 		rc =3D PTR_ERR(sendcq);
> 		dprintk("RPC:       %s: failed to create send CQ: %i\n",
> --=20
> 2.18.0
>=20

--
Chuck Lever