Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15E6BC282C4 for ; Mon, 4 Feb 2019 19:03:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFAAB2082E for ; Mon, 4 Feb 2019 19:03:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727723AbfBDTDL (ORCPT ); Mon, 4 Feb 2019 14:03:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44488 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727673AbfBDTDK (ORCPT ); Mon, 4 Feb 2019 14:03:10 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ABCC687620; Mon, 4 Feb 2019 19:03:10 +0000 (UTC) Received: from [172.16.176.1] (ovpn-112-2.rdu2.redhat.com [10.10.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99E771000049; Mon, 4 Feb 2019 19:03:09 +0000 (UTC) From: "Benjamin Coddington" To: "Trond Myklebust" Cc: anna.schumaker@netapp.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH] NFS: Don't use page_file_mapping after removing the page Date: Mon, 04 Feb 2019 14:03:08 -0500 Message-ID: <22D43CDC-BB14-4C8F-A10E-DF7816EBF0B0@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 04 Feb 2019 19:03:10 +0000 (UTC) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 4 Feb 2019, at 13:32, Trond Myklebust wrote: > On Mon, 2019-02-04 at 13:13 -0500, Benjamin Coddington wrote: >> If nfs_page_async_flush() removes the page from the mapping, then we >> can't >> use page_file_mapping() on it as nfs_updatepate() is wont to do when >> receiving an error. Instead, simplify nfs_zap_mapping() to take the >> inode. >> > > Won't this break NFS swap? I guess it may, but then I wonder: is that a thing that anyone does? It sounds like a terrible idea.. I'm curious enough though, and doing some research on it. Ben