Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH v3] xprtrdma: Make sure Send CQ is allocated on an
 existing compvec
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <9d418664-1f67-c705-19a0-80fc9dc5a12b@suse.com>
Date:   Tue, 5 Feb 2019 12:23:01 -0500
Cc:     linux-rdma <linux-rdma@vger.kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <91CC910C-48A1-4234-8347-39D1A710A87C@oracle.com>
References: <9d418664-1f67-c705-19a0-80fc9dc5a12b@suse.com>
To:     Anna Schumaker <anna.schumaker@netapp.com>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Feb 5, 2019, at 12:21 PM, Nicolas Morey-Chaisemartin =
<nmoreychaisemartin@suse.com> wrote:
>=20
> Make sure the device has at least 2 completion vectors
> before allocating to compvec#1
>=20
> Fixes: a4699f5647f3 (xprtrdma: Put Send CQ in IB_POLL_WORKQUEUE mode)
> Signed-off-by: Nicolas Morey-Chaisemartin =
<nmoreychaisemartin@suse.com>

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

Anna, can you see that this fix gets into v5.0-rc ? Thanks!


> ---
> Changes since v2:
> - Split line for checkpatch to be happy
>=20
> net/sunrpc/xprtrdma/verbs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
> index b725911c0f3f..5fe727a7db82 100644
> --- a/net/sunrpc/xprtrdma/verbs.c
> +++ b/net/sunrpc/xprtrdma/verbs.c
> @@ -546,7 +546,8 @@ rpcrdma_ep_create(struct rpcrdma_ep *ep, struct =
rpcrdma_ia *ia,
>=20
> 	sendcq =3D ib_alloc_cq(ia->ri_device, NULL,
> 			     ep->rep_attr.cap.max_send_wr + 1,
> -			     1, IB_POLL_WORKQUEUE);
> +			     ia->ri_device->num_comp_vectors > 1 ? 1 : =
0,
> +			     IB_POLL_WORKQUEUE);
> 	if (IS_ERR(sendcq)) {
> 		rc =3D PTR_ERR(sendcq);
> 		dprintk("RPC:       %s: failed to create send CQ: %i\n",
> --=20
> 2.18.0

--
Chuck Lever