From:   Kazuo Ito <ito_kazuo_g3@lab.ntt.co.jp>
Subject: [PATCH] pNFS: Avoid read-modify-write for page-aligned full page
 write
Message-ID: <37261782-eebb-b9c5-a480-7ced59b3703f@lab.ntt.co.jp>
Date:   Thu, 7 Feb 2019 17:12:53 +0900
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
To:     Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>
Cc:     linux-nfs@vger.kernel.org,
        Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>,
        watanabe.hiroyuki@lab.ntt.co.jp
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

As the block and SCSI layouts can only read/write fixed-length
blocks, we must perform read-modify-write when data to be written is
not aligned to a block boundary or smaller than the block size.
(612aa983a0410 pnfs: add flag to force read-modify-write in ->write_begin)

The current code tries to see if we have to do read-modify-write
on block-oriented pNFS layouts by just checking !PageUptodate(page),
but the same condition also applies for overwriting of any uncached
potions of existing files, making such operations excessively slow
even if it is block-aligned.

The change does not affect the optimization for modify-write-read
cases (38c73044f5f4d NFS: read-modify-write page updating),
because partial update of !PageUptodate() pages can only happen
in layouts that can do arbitrary length read/write and never
in block-based ones.

Testing results:

We ran fio on one of the pNFS clients running 4.20 kernel
(vanilla and patched) in this configuration to read/write/overwrite
files on the storage array, exported as pnfs share by the server.

  pNFS clients ---1G Ethernet--- pNFS server
  (HP DL360 G8)                  (HP DL360 G8)
        |                              |
        |                              |
        +------8G Fiber Channel--------+
                      |
                Storage Array
                  (HP P6350)

Throughput of overwrite (both buffered and O_SYNC) is noticeably
improved.

Ops.     |block size|   Throughput   |
          |  (KiB)   |    (MiB/s)     |
          |          |  4.20 | patched|
---------+----------+----------------+
buffered |         4|  21.3 |  233   |
overwrite|        32|  22.2 |  254   |
          |       512|  22.4 |  258   |
---------+----------+----------------+
O_SYNC   |         4|   3.84|    4.68|
overwrite|        32|  12.2 |   32.9 |
          |       512|  18.5 |  151   |
---------+----------+----------------+

Read and write (buffered and O_SYNC) by the same client remain unchanged
by the patch either negatively or positively, as they should do.

Ops.     |block size|   Throughput   |
          |  (KiB)   |    (MiB/s)     |
          |          |  4.20 | patched|
---------+----------+----------------+
read     |         4| 548   |  551   |
          |        32| 547   |  552   |
          |       512| 548   |  549   |
---------+----------+----------------+
buffered |         4| 237   |  243   |
write    |        32| 261   |  267   |
          |       512| 265   |  271   |
---------+----------+----------------+
O_SYNC   |         4|   0.46|    0.46|
write    |        32|   3.60|    3.61|
          |       512| 105   |  108   |
---------+----------+----------------+

Signed-off-by: Kazuo Ito <ito_kazuo_g3@lab.ntt.co.jp>
Tested-by: Hiroyuki Watabane <watanabe.hiroyuki@lab.ntt.co.jp>

diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 29553fdba8af..e80954c96ec1 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -276,6 +276,12 @@ EXPORT_SYMBOL_GPL(nfs_file_fsync);
   * then a modify/write/read cycle when writing to a page in the
   * page cache.
   *
+ * Some pNFS layout drivers can only read/write at a certain block
+ * granularity like all block devices and therefore we must perform
+ * read/modify/write whenever a page hasn't read yet and the data
+ * to be written there is not aligned to a block boundary and/or
+ * smaller than the block size.
+ *
   * The modify/write/read cycle may occur if a page is read before
   * being completely filled by the writer.  In this situation, the
   * page must be completely written to stable storage on the server
@@ -299,8 +305,10 @@ static int nfs_want_read_modify_write(struct file 
*file, struct page *page,
  	unsigned int end = offset + len;

  	if (pnfs_ld_read_whole_page(file->f_mapping->host)) {
-		if (!PageUptodate(page))
-			return 1;
+		if (!PageUptodate(page)) {
+			if (pglen && (end < pglen || offset))
+				return 1;
+		}
  		return 0;
  	}