Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67AD1C169C4 for ; Fri, 8 Feb 2019 15:50:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2EBC82086C for ; Fri, 8 Feb 2019 15:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727134AbfBHPux (ORCPT ); Fri, 8 Feb 2019 10:50:53 -0500 Received: from fieldses.org ([173.255.197.46]:56668 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726934AbfBHPux (ORCPT ); Fri, 8 Feb 2019 10:50:53 -0500 Received: by fieldses.org (Postfix, from userid 2815) id E97691C97; Fri, 8 Feb 2019 10:50:52 -0500 (EST) Date: Fri, 8 Feb 2019 10:50:52 -0500 From: "J. Bruce Fields" To: Amir Goldstein Cc: Jeff Layton , Volker.Lendecke@sernet.de, samba-technical@lists.samba.org, Linux NFS Mailing List , linux-fsdevel , Pavel Shilovsky Subject: Re: Better interop for NFS/SMB file share mode/reservation Message-ID: <20190208155052.GB20573@fieldses.org> References: <379106947f859bdf5db4c6f9c4ab8c44f7423c08.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Fri, Feb 08, 2019 at 04:45:46PM +0200, Amir Goldstein wrote: > - check_conflicting_open() is changed to use inode_is_open_for_read() > instead of checking d_count and i_count. Independently of the rest, I'd love to do away with those d_count/i_count checks. What's inode_is_open_for_read()? --b.