Subject: Re: [PATCH] nfs: drop acl cache in __nfs3_proc_setacls
To:     <trond.myklebust@hammerspace.com>, <anna.schumaker@netapp.com>
CC:     <houtao1@huawei.com>, <zhangxiaoxu5@huawei.com>,
        <yi.zhang@huawei.com>, <linux-nfs@vger.kernel.org>
References: <20190220072925.103352-1-yangerkun@huawei.com>
From:   yangerkun <yangerkun@huawei.com>
Message-ID: <36623ffc-100a-8abc-451d-0c8a911482b5@huawei.com>
Date:   Fri, 22 Feb 2019 15:35:10 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190220072925.103352-1-yangerkun@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

Ping?

yangerkun wrote on 2019/2/20 15:29:
> Since server may call posix_acl_update_mode which can lead acl been
> NULL. So,just drop acl cache after rpc_call_sync, and if anyone want to
> use acl, they can get the correct acl by send a msg to server themselves.
> This can fix xfstests generic/099 over nfsv3.
> 
> Signed-off-by: yangerkun <yangerkun@huawei.com>
> ---
>   fs/nfs/nfs3acl.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfs/nfs3acl.c b/fs/nfs/nfs3acl.c
> index 9fce185..6c07ebc 100644
> --- a/fs/nfs/nfs3acl.c
> +++ b/fs/nfs/nfs3acl.c
> @@ -222,8 +222,8 @@ static int __nfs3_proc_setacls(struct inode *inode, struct posix_acl *acl,
>   	switch (status) {
>   		case 0:
>   			status = nfs_refresh_inode(inode, fattr);
> -			set_cached_acl(inode, ACL_TYPE_ACCESS, acl);
> -			set_cached_acl(inode, ACL_TYPE_DEFAULT, dfacl);
> +			/* Sever may call posix_acl_update_mode */
> +			forget_all_cached_acls(inode);
>   			break;
>   		case -EPFNOSUPPORT:
>   		case -EPROTONOSUPPORT:
>