Date:   Mon, 25 Feb 2019 09:49:37 +0100 (CET)
From:   "Mkrtchyan, Tigran" <tigran.mkrtchyan@desy.de>
To:     Dave Noveck <davenoveck@gmail.com>
Cc:     Marc Eshel <eshel@us.ibm.com>,
        linux-nfs <linux-nfs@vger.kernel.org>,
        Ganesha-devel <devel@lists.nfs-ganesha.org>,
        NFSv4 <nfsv4@ietf.org>,
        linux-nfs-owner <linux-nfs-owner@vger.kernel.org>
Message-ID: <741516773.7109032.1551084577150.JavaMail.zimbra@desy.de>
In-Reply-To: <CADaq8jfT=nxmVPz4mDRFAaOx36uxWqKbxitqS-YH3GCOs4CsrQ@mail.gmail.com>
References: <155049372736.14318.3390584694682770373.idtracker@ietfa.amsl.com> <CADaq8je2Ap4oAZAPOguaWctUs8dQ=Q9g=TO39EOiJW5EJSFTGg@mail.gmail.com> <OFE5A6CD32.4DC48078-ON882583A9.007FB4BC-882583A9.0080ACAC@notes.na.collabserv.com> <CADaq8jfT=nxmVPz4mDRFAaOx36uxWqKbxitqS-YH3GCOs4CsrQ@mail.gmail.com>
Subject: Re: [nfsv4] file size and getattr
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Thread-Topic: file size and getattr
Thread-Index: xB45BipLgBZpsCd+0L6G4OWR1hcJRg==
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


----- Original Message -----
> From: "Dave Noveck" <davenoveck@gmail.com>
> To: "Marc Eshel" <eshel@us.ibm.com>
> Cc: "linux-nfs" <linux-nfs@vger.kernel.org>, "Ganesha-devel" <devel@lists.nfs-ganesha.org>, "NFSv4" <nfsv4@ietf.org>,
> "linux-nfs-owner" <linux-nfs-owner@vger.kernel.org>
> Sent: Saturday, February 23, 2019 12:38:56 AM
> Subject: Re: [nfsv4] file size and getattr

>> Does the NFSv4 spec allows the server to return file size that doesn't
>> include the unstable write to the writer or any other NFS client?
> 
> I would say "no".   Consider the followiing sentence in the description of
> COMMIT.
> 

I would say "yes". Let's have a look at LAYOUTCOMMIT. Spec says:

"The metadata server may
   use this information to determine whether the file's size needs to be
   updated.  If the metadata server updates the file's size as the
   result of the LAYOUTCOMMIT operation, it must return the new size
   (locr_newsize.ns_size) as part of the results."

I read this as: Metadata server may not know real file size until client sends
the file size information. Our DSes return DATA_SYNC and relay on client to
issue LAYOUTCOMMIT to update file size (well, on close we force data servers
up update file anyway).

Tigran. 


>> If the count is zero, a flush from the offset to the end of the file is
> done.
> 
> Note that he size returned by GETATTR gives you the end of the file so
> that, if it did not
> reflect the unstable writes, COMMIT wouldn't work right.
> 
> On Fri, Feb 22, 2019 at 6:25 PM Marc Eshel <eshel@us.ibm.com> wrote:
> 
>> What is the file size returned by the NFS server for getattr after an
>> unstable write to the NFS client that did the write or to other NFS
>> clients.
>>
>> As far as I know most file systems will always return the file size that
>> includes the unstable writes.
>>
>> Does the NFSv4 spec allows the server to return file size that doesn't
>> include the unstable write to the writer or any other NFS client?
>>
>> Marc.
>>
>>
> 
> _______________________________________________
> nfsv4 mailing list
> nfsv4@ietf.org
> https://www.ietf.org/mailman/listinfo/nfsv4