Date:   Wed, 27 Feb 2019 18:37:36 +0100
From:   Patrick Steinhardt <ps@pks.im>
To:     Steve Dickson <SteveD@RedHat.com>
Cc:     linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/3] svc_socket: fix use of undefined macro
 HAVE_GETRPCBYNUMBER_R
Message-ID: <20190227173736.GA1893@xps>
References: <a6f2aaea93c1293e62d5109b10d47a7675a45393.1549290423.git.ps@pks.im>
 <5e9826aa52e17d30d7cfee0d3828c5dbecdbfc41.1549290423.git.ps@pks.im>
 <b4f940b5-d073-7aff-7f20-0644a6e57be4@RedHat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP"
Content-Disposition: inline
In-Reply-To: <b4f940b5-d073-7aff-7f20-0644a6e57be4@RedHat.com>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


--5mCyUwZo2JvN/JJP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 27, 2019 at 12:16:18PM -0500, Steve Dickson wrote:
>=20
>=20
> On 2/4/19 9:31 AM, Patrick Steinhardt wrote:
> > The macro HAVE_GETRPCBYNUMBER_R is set based on whether the
> > `getrpcbynumber_r` function was found by autoconf or not. While another
> > location correctly checks whether it is set by using `#ifdef`,
> > `getservport()` instead wrongly uses `#if HAVE_GETRPCBYNUMBER_R`. This
> > may cause a compilation error with gcc with "-Werror=3Dundef" if the ma=
cro
> > has not been defined.
> >=20
> > Fix the error by using `#ifdef` instead.
> >=20
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>
> Committed...
>=20
> BTW... If the future, feel free to ping me it appears=20
> patches slide off my radar... like these did... ;-(=20
>=20
> steved.

Will do. I know from my own experience that it's hard to keep
track and be able to always respond in time :)

So thanks for your review and for committing them.

Patrick

--5mCyUwZo2JvN/JJP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEtmscHsieVjl9VyNUEXxntp6r8SwFAlx2yuAACgkQEXxntp6r
8SxTUg//SyiVeQKPiPyvHoXNGUJCNNoVt7R4wUdWCbTMjBl0LX5XTPu9KYze40jp
Q6HJizzwhU+6+mrOm5MTuXykKslPKx9ZkAoLoihzOcHeLQoeuhQhrWJbv8rDzzmj
gxFoSz6zCsCWSGMgJUKZFArdP28SnMVP6NpURvt/WCnV+wOUm2Fhomf1tfOB8Idj
WVl5/ui5qzwNloLI/HIjjzuJUl9e1anCfmssjLIbJ5eSHiPfzACE1cHHkjIR86Gs
YiuIdhGA+eOCO3DpSLN7MeFRFYjC7j7+pocViUtbF1Sj6pF05Re/Kca/ZzAPfrjf
QMwpfVh9gQNZHOVIdIe3ew1wCJ8vyREFUSYhYPLDQgw5Y+f65ayvtAfYsLnnBlj0
6XkUMH1F9So2AFrAipMN6LXMbkw0+Q2JSgXNgr2or6E7PglQX4w0EN7mYTRt7/iF
aF1+xFw5/cfFPXdz8AqEk38AaYOjBMCJ89BbG5rRXpM7rqY11We1382u05p2QwCW
e4T2d45HqXqrV5EI22THSKW7qX/y58iPHe4Vub+XhIXMSFQSic7uoL10o1fOBe1Z
UEIWR8kOmP9il1XswQGlwLvYwj5snflwocINbjE0yFMRDmNIUwSzpnQ4oPWXxWKr
T3Ouj6osWZDI/N0XI5j8UlUOKMDgalwiZ2bJkLu9ssYau428gj0=
=hNAS
-----END PGP SIGNATURE-----

--5mCyUwZo2JvN/JJP--