MIME-Version: 1.0
References: <CACyXjPx84Y9jwrAQzvhjDz2jH8aZnx8MsvJjQvW9FzDfZy0HCQ@mail.gmail.com>
In-Reply-To: <CACyXjPx84Y9jwrAQzvhjDz2jH8aZnx8MsvJjQvW9FzDfZy0HCQ@mail.gmail.com>
From:   Richard Sharpe <realrichardsharpe@gmail.com>
Date:   Thu, 7 Mar 2019 07:01:54 -0800
Message-ID: <CACyXjPx0oxRhKiSm1AJU9pQ27FEMHYuAnhfLO_NSV20fQVgmyA@mail.gmail.com>
Subject: Re: Check that an RPC compiler has been installed
To:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 6, 2019 at 5:17 PM Richard Sharpe
<realrichardsharpe@gmail.com> wrote:
>
> When I installed Fedora-29 to check out building on Fedora I didn't
> have rpcgen installed.
>
> autogen worked and configure worked but make failed in spectacular ways.
>
> The attached patch warns the user during configure but is perhaps not
> the correct test, because of rpcgen is on your path but not where the
> earlier tests expect it, things will still likely fail.

Here is a better version. Since we already know we didn't find rpcgen,
just let the user know.

Tested by uninstalling rpcgen.

From 6caea95ccebb5d3635b3d1c91e8683954fe61645 Mon Sep 17 00:00:00 2001
From: root <realrichardsharpe@gmail.com>
Date: Wed, 6 Mar 2019 19:51:12 -0500
Subject: [PATCH] If we don't find rpcgen let the user know about it rather
 than getting an error later during make.

---
 configure.ac | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configure.ac b/configure.ac
index cb9d921..b23bb6a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -154,6 +154,9 @@ AC_ARG_WITH(rpcgen,
        if test "$rpcgen_path" =3D "yes"; then
            for p in /usr/local/bin/rpcgen /usr/bin/rpcgen /bin/rpcgen
            do if test -f $p ; then RPCGEN_PATH=3D$p ; break; fi ; done
+           if test -z "$RPCGEN_PATH"; then
+                AC_MSG_ERROR([Please install rpcgen or use --with-rpcgen])
+           fi
        elif test "$rpcgen_path" !=3D "internal"; then
            RPCGEN_PATH=3D$rpcgen_path
        else
--
2.19.1


--=20
Regards,
Richard Sharpe
(=E4=BD=95=E4=BB=A5=E8=A7=A3=E6=86=82=EF=BC=9F=E5=94=AF=E6=9C=89=E6=9D=9C=
=E5=BA=B7=E3=80=82--=E6=9B=B9=E6=93=8D)(=E4=BC=A0=E8=AF=B4=E6=9D=9C=E5=BA=
=B7=E6=98=AF=E9=85=92=E7=9A=84=E5=8F=91=E6=98=8E=E8=80=85)