Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH v2 3/5] NFSD: Remove ima_file_check call
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <20190308211016.GB27011@fieldses.org>
Date:   Fri, 8 Mar 2019 16:11:06 -0500
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        linux-integrity@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <ECE4FD20-840C-4047-9454-27BDF0A905EA@oracle.com>
References: <20190307151838.11306.94183.stgit@manet.1015granger.net>
 <20190307152854.11306.84006.stgit@manet.1015granger.net>
 <20190308211016.GB27011@fieldses.org>
To:     Bruce Fields <bfields@fieldses.org>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Mar 8, 2019, at 4:10 PM, bfields@fieldses.org wrote:
>=20
> On Thu, Mar 07, 2019 at 10:28:54AM -0500, Chuck Lever wrote:
>> The NFS server needs to allow NFS clients to perform their own
>> attestation and measurement.
>=20
> Can we really remove this call?

Why wouldn't we be able to?


> --b.
>=20
>>=20
>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>> ---
>> fs/nfsd/vfs.c |    6 ------
>> 1 file changed, 6 deletions(-)
>>=20
>> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
>> index 3c00072..524c6e5 100644
>> --- a/fs/nfsd/vfs.c
>> +++ b/fs/nfsd/vfs.c
>> @@ -802,12 +802,6 @@ static int nfsd_open_break_lease(struct inode =
*inode, int access)
>> 		goto out_nfserr;
>> 	}
>>=20
>> -	host_err =3D ima_file_check(file, may_flags);
>> -	if (host_err) {
>> -		fput(file);
>> -		goto out_nfserr;
>> -	}
>> -
>> 	if (may_flags & NFSD_MAY_64BIT_COOKIE)
>> 		file->f_mode |=3D FMODE_64BITHASH;
>> 	else

--
Chuck Lever