Date:   Fri, 8 Mar 2019 16:23:10 -0500
From:   Bruce Fields <bfields@fieldses.org>
To:     Chuck Lever <chuck.lever@oracle.com>
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2 3/5] NFSD: Remove ima_file_check call
Message-ID: <20190308212310.GB28002@fieldses.org>
References: <20190307151838.11306.94183.stgit@manet.1015granger.net>
 <20190307152854.11306.84006.stgit@manet.1015granger.net>
 <20190308211016.GB27011@fieldses.org>
 <ECE4FD20-840C-4047-9454-27BDF0A905EA@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ECE4FD20-840C-4047-9454-27BDF0A905EA@oracle.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 08, 2019 at 04:11:06PM -0500, Chuck Lever wrote:
> 
> 
> > On Mar 8, 2019, at 4:10 PM, bfields@fieldses.org wrote:
> > 
> > On Thu, Mar 07, 2019 at 10:28:54AM -0500, Chuck Lever wrote:
> >> The NFS server needs to allow NFS clients to perform their own
> >> attestation and measurement.
> > 
> > Can we really remove this call?
> 
> Why wouldn't we be able to?

I don't know the first thing about IMA, but surely it's there for some
reason--is it really OK just to skip this on opens by nfsd?

--b.

> >> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> >> ---
> >> fs/nfsd/vfs.c |    6 ------
> >> 1 file changed, 6 deletions(-)
> >> 
> >> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> >> index 3c00072..524c6e5 100644
> >> --- a/fs/nfsd/vfs.c
> >> +++ b/fs/nfsd/vfs.c
> >> @@ -802,12 +802,6 @@ static int nfsd_open_break_lease(struct inode *inode, int access)
> >> 		goto out_nfserr;
> >> 	}
> >> 
> >> -	host_err = ima_file_check(file, may_flags);
> >> -	if (host_err) {
> >> -		fput(file);
> >> -		goto out_nfserr;
> >> -	}
> >> -
> >> 	if (may_flags & NFSD_MAY_64BIT_COOKIE)
> >> 		file->f_mode |= FMODE_64BITHASH;
> >> 	else
> 
> --
> Chuck Lever
> 
>