Date:   Fri, 15 Mar 2019 15:52:33 -0400
From:   Scott Mayhew <smayhew@redhat.com>
To:     "J. Bruce Fields" <bfields@fieldses.org>
Cc:     jlayton@kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [pynfs PATCH 1/4] nfs4.1: add some reboot tests
Message-ID: <20190315195233.GY4975@coeurl.usersys.redhat.com>
References: <20190314211210.7454-1-smayhew@redhat.com>
 <20190314211210.7454-2-smayhew@redhat.com>
 <20190315194344.GA13567@fieldses.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190315194344.GA13567@fieldses.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On Fri, 15 Mar 2019, J. Bruce Fields wrote:

> On Thu, Mar 14, 2019 at 05:12:07PM -0400, Scott Mayhew wrote:
> > +def doTestRebootWithNClients(t, env, n=10):
> > +    boot_time = int(time.time())
> > +    lease_time = 90
> 
> Looks like these two variables aren't used till they're set again a
> little further down, so I'll delete these two lines.

The intention there was to have some default values for the exception
handler if the test were to barf right away for some reason.
> 
> --b.
> 
> > +    states = []
> > +    block = env.c1.new_client_session("%s_block" % env.testname(t))
> > +    for i in range(n):
> > +        name = "%s_client_%i" % (env.testname(t), i)
> > +        owner = "owner_%s" % name
> > +        c = env.c1.new_client(name)
> > +        sess = c.create_session()
> > +        reclaim_complete(sess)
> > +        fh, stateid = create_confirm(sess, owner)
> > +        states.append(State(name, owner, c, sess, fh))
> > +    lease_time = _getleasetime(sess)
> > +    boot_time = _waitForReboot(env)