Subject: Re: [PATCH] nfsiostat: replace 'list' reserved word
To:     Matthew Ruffell <matthew.ruffell@canonical.com>,
        linux-nfs@vger.kernel.org
References: <20190324213318.18296-1-matthew.ruffell@canonical.com>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <d5103bda-5c81-5e7c-afe6-1b9e18c60d8b@RedHat.com>
Date:   Thu, 28 Mar 2019 16:06:05 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.0
MIME-Version: 1.0
In-Reply-To: <20190324213318.18296-1-matthew.ruffell@canonical.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 3/24/19 5:33 PM, Matthew Ruffell wrote:
> list is a reserved word in python and should not be used as a variable
> name. Changing list to devicelist for list_nfs_mounts()
> 
> Fixes: https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/1821261
> 
> Signed-off-by: Matthew Ruffell <matthew.ruffell@canonical.com>
Committed...

steved.
> ---
>  tools/nfs-iostat/nfs-iostat.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/nfs-iostat/nfs-iostat.py b/tools/nfs-iostat/nfs-iostat.py
> index 7cbe543..dec0e86 100644
> --- a/tools/nfs-iostat/nfs-iostat.py
> +++ b/tools/nfs-iostat/nfs-iostat.py
> @@ -493,20 +493,20 @@ def list_nfs_mounts(givenlist, mountstats):
>         return a full list if the given list is empty -
>         may return an empty list if none found
>      """
> -    list = []
> +    devicelist = []
>      if len(givenlist) > 0:
>          for device in givenlist:
>              stats = DeviceData()
>              stats.parse_stats(mountstats[device])
>              if stats.is_nfs_mountpoint():
> -                list += [device]
> +                devicelist += [device]
>      else:
>          for device, descr in mountstats.items():
>              stats = DeviceData()
>              stats.parse_stats(descr)
>              if stats.is_nfs_mountpoint():
> -                list += [device]
> -    return list
> +                devicelist += [device]
> +    return devicelist
>  
>  def iostat_command(name):
>      """iostat-like command for NFS mount points
>