Subject: Re: [PATCH] mount: Add missing cast to getsockname
To:     Rosen Penev <rosenp@gmail.com>, linux-nfs@vger.kernel.org
References: <20190415020838.924-1-rosenp@gmail.com>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <ee4c0c64-4a3b-555b-2299-251e1c76774e@RedHat.com>
Date:   Tue, 16 Apr 2019 14:28:19 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190415020838.924-1-rosenp@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 4/14/19 10:08 PM, Rosen Penev wrote:
> Otherwise compilation can fail with incompatible pointer type.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Committed.... 

steved.

> ---
>  utils/mount/network.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/mount/network.c b/utils/mount/network.c
> index fc21110..e166a82 100644
> --- a/utils/mount/network.c
> +++ b/utils/mount/network.c
> @@ -1062,7 +1062,7 @@ int clnt_ping(struct sockaddr_in *saddr, const unsigned long prog,
>  	if (caddr) {
>  		/* Get the address of our end of this connection */
>  		socklen_t len = sizeof(*caddr);
> -		if (getsockname(sock, caddr, &len) != 0)
> +		if (getsockname(sock, (struct sockaddr *) caddr, &len) != 0)
>  			caddr->sin_family = 0;
>  	}
>  
>