Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <7F460FEA-BD69-4559-926C-5C1B0CF90E3C@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_EB3E3A59-94EE-44CC-8383-078B4B992E50";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH 08/10] nfsd4: add file to display list of client's opens
Date:   Thu, 25 Apr 2019 23:14:23 +0200
In-Reply-To: <20190425201413.GB9889@fieldses.org>
Cc:     Jeff Layton <jlayton@redhat.com>,
        "J. Bruce Fields" <bfields@redhat.com>,
        linux-nfs <linux-nfs@vger.kernel.org>,
        linux-fsdevel@vger.kernel.org, abe@purdue.edu,
        lsof-l@lists.purdue.edu, util-linux@vger.kernel.org
To:     "J. Bruce Fields" <bfields@fieldses.org>
References: <1556201060-7947-1-git-send-email-bfields@redhat.com>
 <1556201060-7947-9-git-send-email-bfields@redhat.com>
 <d26e7611f4e610bff81a16abbb88ca1c5ed70c91.camel@redhat.com>
 <20190425201413.GB9889@fieldses.org>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


--Apple-Mail=_EB3E3A59-94EE-44CC-8383-078B4B992E50
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On Apr 25, 2019, at 10:14 PM, J. Bruce Fields <bfields@fieldses.org> wrote:
> 
> On Thu, Apr 25, 2019 at 02:04:59PM -0400, Jeff Layton wrote:
>> More bikeshedding: should we have a "states" file instead of an "opens"
>> file and print a different set of output for each stateid type?
> 
> Sure.  The format of the file could be something like
> 
> 	<stateid> open rw -- <openowner>...
> 	<stateid> lock r 0-EOF <lockowner>...
> 	<stateid> deleg r
> 
> I wonder if we could put owners on separate lines and do some
> heirarchical thing to show owner-stateid relationships?  Hm.  That's
> kind of appealing but more work.

My suggestion here would be to use YAML-formatted output rather than
space/tab separated positional fields.  That can still be made human
readable, but also machine parseable and extensible if formatted properly.

Something like the following (use https://yaml-online-parser.appspot.com/
to validate the formatting):

- <stateid>: { state: open, mode: rw, owner: <openowner> }
- <stateid>: { state: lock, mode: r, start: 0, end: EOF, owner: <openowner> }


> I was only planning to do opens for the first iteration, and I think
> extending later in separate files is slightly safer.
> 
> More trivial, but: it'd lengthen lines and make columns line up less
> often.  But if we include a lot of long variable-length fields then
> that's kinda hopeless anyway.
> 
> --b.


Cheers, Andreas


--Apple-Mail=_EB3E3A59-94EE-44CC-8383-078B4B992E50
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAlzCIzAACgkQcqXauRfM
H+DlOw//VSr+buQMPY+uIy7a+0sVuPJbaxqgSkrvlzeyVcyPRwlvYSiZ4ZyhCIYT
hH9QvT+SpWVLOQlReuRxmZJh64kTpuSuFzPNII5NF5JRcbNfmitpltylSNzLovIZ
m0fwuVGylQwNMdhltPuGpngAIzg6TkdoI14qKyQ17PV+sdWma8Zb7C+XTXdAItGM
xI9PtRlTTGs6/jYd8C3yTT03qcNoUbK1eLAbN002MiWWMIvllZ3aeXncQbTIJIr2
dcZyCTYo47iDo2lkulvKKO62IjyPw6Oh+VsfgjB6i1LJrUFqUYTJYT72YutQ+LS5
bIs9XK619RwEOClPqbtpSIXGaTuEK+Dh7rZF58cl65OzamseuxYk0YhQNHoZds/5
HgGjwLbPH5CEr9j+sc07iWjbNH1KWWckryBTYG1KLthHw40hS9WZp2HIr/6mp3PN
Z08tti2uuAndjMXZ0NoPQdF/yo0NtQ1PzI8C+VCmEcysIY+5fx6GR4VOQk96/f2E
m1m2D8ooKZ1WV/MDLX90inSNRdQFgj7bAFfDp0BVv2ywpAe5GxnsZCx97VMizwhj
h33Kvw9pznMf6yQDITypFJ98N8g8P1QqwMEAaEgLtgXAHv+nVLPn1SnGnH43DuSu
pZOpH4f+6mc7U8RxawDgiTOc06p51gxqaegRrtROu41ZiZp/hMw=
=sOWl
-----END PGP SIGNATURE-----

--Apple-Mail=_EB3E3A59-94EE-44CC-8383-078B4B992E50--