Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6274781yba; Wed, 1 May 2019 09:07:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqy703f3loCvbRCuMwUm3I1KCj5328u2/9WigkzyONytHr/sLvaGtCBcoLlSgDJixhMtntyA X-Received: by 2002:a17:902:6b44:: with SMTP id g4mr24671803plt.157.1556726871208; Wed, 01 May 2019 09:07:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556726871; cv=none; d=google.com; s=arc-20160816; b=u6obn8Fjx1GjCqDxAgByGnaKH9EVLrSzZ6w0Se7XBKdOyOROxJnYiywwDC3B+GvRTo +Ht/R/NrTCr99nd24co8aGyVZNod50Ho0FXmini9fhHxptalg4iEv+hsTIwcwp89LJDV 5JiSHICeKe3//msB5ivvCBYStdjJ2XQ4rDrTqtOT6yBLzLNlzWxipt32HbfHVJjlx06Y OlyUzz0kSVGCCSwZgTbgsuWyt55i9jtwavQkuo/FWUAk79Gtuaqjr7H26E45nvsSImos m2otvG18ByLFIPqFrzNmPeA7CB9SDSNNM0AMLgIfzIUtSQxGuYZMUC578UrladsFIl3k s8QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=BmsOCWOL+giQZS37PMaeMlSUUcjDPMjoPtCe2tkT52w=; b=eb+D71GfugcueVaB8SiaiZgsVptbumrSKe0JuidIQimrA1xbT90zd3IlZXQJXvJgxd y69b4URWujP+RTVXxs4eDPtY8BF7uDQPsMp3XTJd8qQgSBpoINEt7ms0pDsFOpqeEHRN wAPfadnNbJ1c9JQeKaLsZqOx3l5Oa5VpGI0H3aHVqXJar4all8UdiVJxig2gtbr4JoPt yKp3eoFmUsZDmSh0FgobHUw/++ost+KKl1hLuZohAAG36pnbtI6ICvzKx7Ovkfh3zW9M a2LiiGzte4Y3wUGZhHV7hVJHSxZ8zY6HPAzu5fCZQ1l6eFb37q0McU1Evta9p9tAQ9sy 7O+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=lhopa3nn; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r26si38947784pgv.523.2019.05.01.09.07.23; Wed, 01 May 2019 09:07:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=lhopa3nn; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726473AbfEAQHS (ORCPT + 99 others); Wed, 1 May 2019 12:07:18 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:35032 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726388AbfEAQHS (ORCPT ); Wed, 1 May 2019 12:07:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BmsOCWOL+giQZS37PMaeMlSUUcjDPMjoPtCe2tkT52w=; b=lhopa3nnuzOqrafzg9Kkz+1vj zRcrs1JNVduVklckswJUOJDeGXueBDJQqfe1bSXKFFYz+EsgYkSK7QTDiq3dyTN5Zu8rRkrb/ofe5 iy9J+NYQ3/g3/e7Zat5sBySIWPF6fPyuj2jZ6mPvZrOwkVDcX0us/ysxTVD3wQzLoAtP/7/+Ys2/w pPThqLdy0UCS/EfbjlATohXf8BTo98B+eFvbYkSIsp0MfV8tc20cD0hvWpavUXG2l7N44tjLh3AQv JF2JvKvOFoXfDZCheLkQDFGqx0qyb9unfIa7+drB+xOUy2K53E4eWNNsYhLcV5F7gFtvRxhMTTIhR NT/oC7BdA==; Received: from adsl-173-228-226-134.prtc.net ([173.228.226.134] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLrlJ-0008Km-QG; Wed, 01 May 2019 16:07:14 +0000 From: Christoph Hellwig To: Andrew Morton Cc: Sami Tolvanen , Kees Cook , Nick Desaulniers , linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: fix filler_t callback type mismatches Date: Wed, 1 May 2019 12:06:32 -0400 Message-Id: <20190501160636.30841-1-hch@lst.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Casting mapping->a_ops->readpage to filler_t causes an indirect call type mismatch with Control-Flow Integrity checking. This change fixes the mismatch in read_cache_page_gfp and read_mapping_page by adding using a NULL filler argument as an indication to call ->readpage directly, and by passing the right parameter callbacks in nfs and jffs2.