Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp7379014yba;
        Thu, 2 May 2019 08:53:11 -0700 (PDT)
X-Google-Smtp-Source: APXvYqxdicHwGaSH0QXOOYOFK0HXlF8rsYEs6w3G75JsnsKRmp+JqRXPOZkvM+UByCFXSyutiCo/
X-Received: by 2002:a63:8f4b:: with SMTP id r11mr4747808pgn.271.1556812391138;
        Thu, 02 May 2019 08:53:11 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1556812391; cv=none;
        d=google.com; s=arc-20160816;
        b=jcAxdFvvnj9jLmpvL3BtgGuq733UMHKTa23KAdmNjnB+6RM2MMCiirKSygbxA+CX8p
         Sv94Y10ovAfUzGg8Jf6s8g9p6N6y16XhvCZaIloLcHb+eVeCC4CF5VRgASfEJrOixcMb
         01ooT3AIZ4dFIFUwgmmkBCdiMd5ehsGSN/dRqPl+e1r1nC/mpj+uRl7vTgovV+eWDnIr
         vDlZ5KbHBEjeUEHARlOAjn0W6OxsonqM6WNVd6du9evGpevgdZj5yUOpGU8ICvTE6iXl
         n+6glOqC2rz8duYHdRNt9j9Fkb/jjlATHBCox9bu/YPWknl3Xo/U1Z40I6RuKLX6WTRw
         tfgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from;
        bh=E1FEAXykea+Iwq1S+PyjoovZRmQLQnS8SzxZ2VIIZus=;
        b=LGHPHgCOxebtQnDf+PI4hAR16y7PcLeIzOv/DCtjdEnsJ1YExELVBkHu6JNdzZJPm/
         B0U2NZ4NHm4oYr1xOZwU8TIghNEry1LrhoRe82t+t14261/PlHqQqO0/4/IOa7Zjb2T5
         R0r0vxISCuFOLP4ES9nt/LNVaOsjy9SQMLN+8WrsPs2Vs5tKGFuhu2eJycm1r5+8y+9k
         MTxVOAjSIzZvmT6JuD6r3G8eAI3VXpJN8pvBzdJL0u0P32JzXESLZtBsMcC4yzvw14ct
         Oc2MjtEk4xZatnchR4jtKxBOPTvRjTaRQUhPg9PmVXIvE2FDFLgghMxdamEc4qrXZLzk
         1ADw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Return-Path: <linux-nfs-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id d129si22864732pfd.267.2019.05.02.08.52.54;
        Thu, 02 May 2019 08:53:11 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726336AbfEBPww (ORCPT <rfc822;linux.lists.archive@gmail.com>
        + 99 others); Thu, 2 May 2019 11:52:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55380 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726334AbfEBPww (ORCPT <rfc822;linux-nfs@vger.kernel.org>);
        Thu, 2 May 2019 11:52:52 -0400
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
        (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
        (No client certificate requested)
        by mx1.redhat.com (Postfix) with ESMTPS id B37CC307D983;
        Thu,  2 May 2019 15:52:51 +0000 (UTC)
Received: from [10.10.66.66] (ovpn-66-66.rdu2.redhat.com [10.10.66.66])
        by smtp.corp.redhat.com (Postfix) with ESMTPS id F31305DA5B;
        Thu,  2 May 2019 15:52:50 +0000 (UTC)
From:   "Benjamin Coddington" <bcodding@redhat.com>
To:     "Roberto Bergantinos Corpas" <rbergant@redhat.com>
Cc:     linux-nfs@vger.kernel.org, trond.myklebust@hammerspace.com,
        anna.schumaker@netapp.com
Subject: Re: [PATCH] NFS: make nfs_match_client killable
Date:   Thu, 02 May 2019 11:52:49 -0400
Message-ID: <7D6BA417-B507-4359-8168-450690A09E49@redhat.com>
In-Reply-To: <20190425133651.17618-1-rbergant@redhat.com>
References: <20190425133651.17618-1-rbergant@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 02 May 2019 15:52:52 +0000 (UTC)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On 25 Apr 2019, at 9:36, Roberto Bergantinos Corpas wrote:

>     Actually we don't do anything with return value from
>     nfs_wait_client_init_complete in nfs_match_client, as a
>     consequence if we get a fatal signal and client is not
>     fully initialised, we'll loop to "again" label
>
>     This has been proven to cause soft lockups on some scenarios
>     (no-carrier but configured network interfaces)
>
> Signed-off-by: Roberto Bergantinos Corpas <rbergant@redhat.com>

This looks right to me.

Reviewed-by: Benjamin Coddington <bcodding@redhat.com>

Ben