Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp414274yba; Fri, 3 May 2019 04:24:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqw4kHWi6WVn2MMtkQNjonP2xuVgdQWsQePz0FCUhtMlHFDd6kMcPGqE7w2bYZlQfVMH1k7X X-Received: by 2002:a62:6444:: with SMTP id y65mr1623040pfb.148.1556882649331; Fri, 03 May 2019 04:24:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556882649; cv=none; d=google.com; s=arc-20160816; b=Fu+58oBzK1+e69MXKdUbEW+CnKGJMn0YDkJ17SyDWXGcx9I9FxI+xYYpIHt/9KbK6e AXq0VkYqsPxv23/ca5NPLJqNnbFEVeo8ZhAuSYCjvl25iJxxdHNXayIoIVKsBhkPuFh2 fqFnRcHUIlkLUIFgWAEMp9wJcrjFQvVFWDvPG5jy1rFprNhROymf1cqaO/IHsLk2p3ZP zm/TUC2pXAYQ2SpxuCgVLNqFRUmyDGm9oLb2AJMXlDVBLvVm2JoINvcZBZW+8DaFgRKb 3g3L3eONVjjyD6yZcc653bkFuS7XMv09W1AzWnQ1nLcCBEnKWutxPpzc+fpQ5smCVDy5 L+WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=8Um/3dZPVhN75ts3t++gUloYm2MjFnE79by4QieaIog=; b=kdYSz9tw+zdaI1S+9WtWkUsMQiP2bJ43m09NA4iG/4PBMhF2AToWIWMTtW7nOQLgVs N+QH+9GTJDFWyKc+Cp7sTXfSLKfTLh26S1lafT2M/a0Ii+Cab4d2Ts8JOMvZb9SQKU9i uab4VbwKGRmI3a33mRYoHM7IU3XUTygq74vHkdXZzrTk9gAFZ5trOBeNkOpQJYzPt9SS JvLynHYadVoE3VE+LzB8JInUP3IOFDBlMHGu8IVsu5wBZktJZyzi1R3/IGtljD4J0JNh 6sguuTQRLf1lDdCm2UXn4N1/hxpczHSR5PqBB2jyj+fUxTYIardyk9OHghygUPB0sN2o xsNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HWGgRIHr; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n72si2021532pfi.0.2019.05.03.04.23.54; Fri, 03 May 2019 04:24:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HWGgRIHr; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726463AbfECLWX (ORCPT + 99 others); Fri, 3 May 2019 07:22:23 -0400 Received: from mail-it1-f195.google.com ([209.85.166.195]:56004 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726377AbfECLWX (ORCPT ); Fri, 3 May 2019 07:22:23 -0400 Received: by mail-it1-f195.google.com with SMTP id i131so8466985itf.5 for ; Fri, 03 May 2019 04:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8Um/3dZPVhN75ts3t++gUloYm2MjFnE79by4QieaIog=; b=HWGgRIHroP1+NoSG0bVpsMJHJKvx4+O/r50+Uc/gf1r618rgrGr8BAiQazabDCS/Gx DpewKurK74dnlhUQlD1RsReq61gz5+xgBEWiITFttwBK01Jwnj84AON/pWg5ZHmYhuvu sLO3RKjPM0dfoM5vDo5a0kGkEBDPcMQM0dBrFMLuYnFJorGIj8afcH3a54boosCJfpfK aYZn3V5bLn7u+qKzdhtJEXNuCZfde+Ho04OxY8dPMq2z2seyeFeTRxYBZ+d3NRGIBuG2 gxwJtdEDx8SXF4NDoG9wbTfZUYRbTTzojrRph8P3Jj0x5a5F2YIxx4LDWO+Qe9yPKKOZ iLDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8Um/3dZPVhN75ts3t++gUloYm2MjFnE79by4QieaIog=; b=B51akJiN8/22gaL8P9WfcF9+OwHqTW92O0acmV8zmqgEMVfi7CmR1csZUWy118x8FT bv7ccHD4PxMj4wStnTflbh/pLGu4rIx+X3OukCHNCo3LDY/vb5CgbTQicjudbx+EYuax tOmDgdmWLQe1D+eEDjWHTWC5XiHQeaHGenawApwyviCFnqm8CL2lZckcM3NRDjDXubZF NBB8538cl+YJcitAg6rXPOCfGCzx5G7YbKkfGCqub1sJ+T7zc6wAKDNoMy6gbJeHP1Ba CjJBRxRbJRH7Q/Vct1u5FtHYHTVvBTawcMcXCuXy/l5Pb5gld0vqBVX7cWdCnK3B9Zf2 P83g== X-Gm-Message-State: APjAAAW2q07QctjM7SwPKh3ni3X3L0LUPzYPrZZBNQdQhPa2rycBQ2Tx mJ2VE61zfmV7DngDw7ko8Rrl9B+IxQ== X-Received: by 2002:a02:8501:: with SMTP id g1mr6779402jai.120.1556882541947; Fri, 03 May 2019 04:22:21 -0700 (PDT) Received: from localhost.localdomain ([8.46.76.65]) by smtp.gmail.com with ESMTPSA id d193sm737325iog.34.2019.05.03.04.22.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 May 2019 04:22:21 -0700 (PDT) From: Trond Myklebust X-Google-Original-From: Trond Myklebust To: Chuck Lever Cc: linux-nfs@vger.kernel.org Subject: [RFC PATCH 0/5] bh-safe lock removal for SUNRPC Date: Fri, 3 May 2019 06:18:36 -0500 Message-Id: <20190503111841.4391-1-trond.myklebust@hammerspace.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org This patchset aims to remove the bh-safe locks on the client side. At this time it should be seen as a toy/strawman effort in order to help the community figure out whether or not there are setups out there that are actually seeing performance bottlenecks resulting from taking bh-safe locks inside other spinlocks. Trond Myklebust (5): SUNRPC: Replace the queue timer with a delayed work function SUNRPC: Replace direct task wakeups from softirq context SUNRPC: Remove the bh-safe lock requirement on xprt->transport_lock SUNRPC: Remove the bh-safe lock requirement on the rpc_wait_queue->lock SUNRPC: Reduce the priority of the xprtiod queue include/linux/sunrpc/sched.h | 3 +- include/linux/sunrpc/xprtsock.h | 5 + net/sunrpc/sched.c | 76 +++++++++------- net/sunrpc/xprt.c | 61 ++++++------- net/sunrpc/xprtrdma/rpc_rdma.c | 4 +- net/sunrpc/xprtrdma/svc_rdma_backchannel.c | 4 +- net/sunrpc/xprtrdma/svc_rdma_transport.c | 8 +- net/sunrpc/xprtsock.c | 101 +++++++++++++++++---- 8 files changed, 168 insertions(+), 94 deletions(-) -- 2.21.0