Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 8 May 2019 11:23:59 +0200
From:   Greg KH <greg@kroah.com>
To:     Yihao Wu <wuyihao@linux.alibaba.com>
Cc:     linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
        "J. Bruce Fields" <bfields@fieldses.org>, stable@vger.kernel.org,
        Joseph Qi <joseph.qi@linux.alibaba.com>,
        caspar@linux.alibaba.com
Subject: Re: [PATCH 2/2] NFSv4.1: Fix bug only the first CB_NOTIFY_LOCK is
 handled
Message-ID: <20190508092359.GA2361@kroah.com>
References: <d0b6fc01-0a73-e4f7-b393-3ecc9aacffb0@linux.alibaba.com>
 <2a1cebca-1efb-1686-475b-a581e50e61b4@linux.alibaba.com>
 <cdba66b5-29a3-e37b-1e0f-808c171d09c3@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cdba66b5-29a3-e37b-1e0f-808c171d09c3@linux.alibaba.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On Wed, May 08, 2019 at 05:15:03PM +0800, Yihao Wu wrote:
> When the first CB_NOTIFY_LOCK wakes a waiter, it can still fail to
> acquire the lock. Then it might goes to sleep again. However it's removed
> from the wait queue and not put back. So when the CB_NOTIFY_LOCK comes
> again, it fails to wake this waiter.
> 
> Signed-off-by: Yihao Wu <wuyihao@linux.alibaba.com>
> ---
>  fs/nfs/nfs4proc.c | 4 ++++
>  1 file changed, 4 insertions(+)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>