Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5023441yba; Wed, 8 May 2019 06:47:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqzlTSqZCGR8devC1wGMGT0nTXtYeNUXfOGSCxdiZjzCOK/0MezAmiM09vMv0MosPrbW+YVA X-Received: by 2002:a62:4607:: with SMTP id t7mr49494045pfa.138.1557323265159; Wed, 08 May 2019 06:47:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557323265; cv=none; d=google.com; s=arc-20160816; b=nfJwAFuZ7KjxQDxkJ4jrd3pYYmImF/uSzOLJp4nZ/qOARvkEznXZfZTGQeRJ7PhJeD u5+FLp6TlQgCtLMJ4rLMU6L3cq7KHFEGmQCvVGOOe3dHtYD6PvBl9w+ktXu+/h6Dbv44 /322OoVcZ24zeeD8aXxMcQ3P/TLTceO80xtncXQxTyCgJoP1u/CySq6gl4XfET9Ra9oO q+OuoerZNTUORKctgza+3UkW+Xg99VQ5NVUuj8RlC/wQBPDtyMdUuT6K/gVCQa517AV8 x6R2lI0GG2UpLTwaVCt0HlKWnCNO6BqTM9YHYi0+QTJIYrbfbtQm3NopSAvn/W8s+Iyq NemA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=b/OXfAr/liyvWdG1+mQKfXOKxWedrlVdSuYxNpmvb7o=; b=a9MMs7KVK+aAY3eDJdzn2ikWO/ou8kRgvpUIVoCQ0BhioWiz/slsZ+/EDmrkv6HI4N SVheN/WDyhr3rYmnJpIJYNpuKTQe9zo9MGmLOIrNqHW5ToNMu4+F8p6P9JW2hJBFs5XV tKqU2D/W9KjJOb5pKkQ4wuDjKJjE5rGcSZURCqiaasb0Nfsn+W0vpalYf6x+Qnpy7yZH h6r7zGf5MsWeWyrkEoFGTSAw84+jqj2WiEdlkf9dz2b2DH+Cws8X1/Ztaof1HB/Y8B2a 6KfCb61l/1sjn5wWjZK2/jc2xwuHcGOrHWu0JMBuc/s1GMrLjUMzqP5Aeu5oIMeX+v2u LiDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m64si24270421pfm.188.2019.05.08.06.47.27; Wed, 08 May 2019 06:47:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726882AbfEHNfl (ORCPT + 99 others); Wed, 8 May 2019 09:35:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57483 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726762AbfEHNfl (ORCPT ); Wed, 8 May 2019 09:35:41 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 196E53087950 for ; Wed, 8 May 2019 13:35:41 +0000 (UTC) Received: from madhat.boston.devel.redhat.com (ovpn-116-59.phx2.redhat.com [10.3.116.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id C46595C269 for ; Wed, 8 May 2019 13:35:40 +0000 (UTC) From: Steve Dickson To: Linux NFS Mailing list Subject: [PATCH 04/19] Removed a resource leak from nfs/rpcmisc.c Date: Wed, 8 May 2019 09:35:21 -0400 Message-Id: <20190508133536.6077-5-steved@redhat.com> In-Reply-To: <20190508133536.6077-1-steved@redhat.com> References: <20190508133536.6077-1-steved@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 08 May 2019 13:35:41 +0000 (UTC) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org nfs/rpcmisc.c:105: leaked_handle: Handle variable "sock" going out of scope leaks the handle. Signed-off-by: Steve Dickson --- support/nfs/rpcmisc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/support/nfs/rpcmisc.c b/support/nfs/rpcmisc.c index abe89ba..d84c04f 100644 --- a/support/nfs/rpcmisc.c +++ b/support/nfs/rpcmisc.c @@ -102,6 +102,7 @@ makesock(int port, int proto) if (bind(sock, (struct sockaddr *) &sin, sizeof(sin)) == -1) { xlog(L_FATAL, "Could not bind name to socket: %s", strerror(errno)); + close(sock); return -1; } -- 2.20.1