Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5023800yba; Wed, 8 May 2019 06:48:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqztYAuBEWuUV12MbOQPaENAnW8uRuAV0G7u4AcKJwMeZ+5NJ7IXAf4x37XPjj8lracfGMHd X-Received: by 2002:a62:2e46:: with SMTP id u67mr8546913pfu.206.1557323285372; Wed, 08 May 2019 06:48:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557323285; cv=none; d=google.com; s=arc-20160816; b=y76i6oFRl0hOUqCjLMSOa3HyGKjiEzeUQ63quv3rY8GY4cdQxWh1BRbsJEoGhfWI7O Wev1DThvZQTUqn0mkMvWIAVWZY0/aXOBjESCSj9Vhi5IPWQ+qPQBjvOUuD2HHAlH4bLj YckPmgpK9fsWlLjierejE89MPDRop02DXdKIXmHQWNWFZCU8t7MY5+0uS6V7UAkgmqw9 5DdaS37h5Fw6eEHTcFhKY9FSSMVPXkaQX2jIQcnV3xPvSV9LZ8gfvECWb2qU1/5nsqmV nEMRDCR8Acv5Wm63l8F3+NpQJg2anogu2l+xvBFKnNFQTyt2JrzcIJMPY0BFS62dc2/g khAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=PeCHHpdqL3GmzUGvmekkORrqvK7ocsz2ebtIs9/a7i0=; b=mtxbk7i8S5RyWIJ6aAOzi9txEC9ZaOvlBpYV+ZlznjeIQlV16BwU/Wpmw7LHl/QwIM odrFYT0tV+tqEweGWVSRhiErZyyclblHvLOjab/YAshn5LjKls3XHB967lwQyTLIg8qX QDLhLstxGfyNodtBWR2lgu9wHam3jUoo5yEOD34XfoRhiqvEN34Rgr7RpRsH3b6Mpt1m nSmjAmomj+K7w7Ockgd6GqYV4k1y5v+SwYFxUUlZ++yNFrOv5HBBM1+mPNbGqay53rVr P7mraioAxTTTSeOucLsRf/IfMnFPRRNz9JjKX6FiWjmNnGrDp5YaY4UXEVmybOkynSxQ 6Eeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t11si15620982pgj.284.2019.05.08.06.47.51; Wed, 08 May 2019 06:48:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727383AbfEHNft (ORCPT + 99 others); Wed, 8 May 2019 09:35:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50498 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727370AbfEHNfs (ORCPT ); Wed, 8 May 2019 09:35:48 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C2FAF2D7FB for ; Wed, 8 May 2019 13:35:48 +0000 (UTC) Received: from madhat.boston.devel.redhat.com (ovpn-116-59.phx2.redhat.com [10.3.116.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7CF591724D for ; Wed, 8 May 2019 13:35:47 +0000 (UTC) From: Steve Dickson To: Linux NFS Mailing list Subject: [PATCH 15/19] Removed a resource leak from mount/nfsmount.c Date: Wed, 8 May 2019 09:35:32 -0400 Message-Id: <20190508133536.6077-16-steved@redhat.com> In-Reply-To: <20190508133536.6077-1-steved@redhat.com> References: <20190508133536.6077-1-steved@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 08 May 2019 13:35:48 +0000 (UTC) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org mount/nfsmount.c:455: leaked_storage: Variable "mounthost" going out of scope leaks the storage it points to. Signed-off-by: Steve Dickson --- utils/mount/nfsmount.c | 1 + 1 file changed, 1 insertion(+) diff --git a/utils/mount/nfsmount.c b/utils/mount/nfsmount.c index 952a755..3d95da9 100644 --- a/utils/mount/nfsmount.c +++ b/utils/mount/nfsmount.c @@ -452,6 +452,7 @@ parse_options(char *old_opts, struct nfs_mount_data *data, nfs_error(_("%s: Bad nfs mount parameter: %s\n"), progname, opt); out_bad: free(tmp_opts); + free(mounthost); return 0; } -- 2.20.1