Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] nfs-utils: Change /var/run -> /run in systemd service
 files
From:   Steve Dickson <SteveD@RedHat.com>
To:     Orion Poplawski <orion@nwra.com>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
References: <6a9ffa7d-f711-026f-d9f7-a680a86c553a@nwra.com>
 <29ea93aa-9f20-9d09-c135-99f5976704db@RedHat.com>
 <c32f477e-4389-6c97-573d-1faa45c2bcff@nwra.com>
 <f53b3ed0-0489-2b94-9f8d-d0120db0c0da@RedHat.com>
Message-ID: <6e64dc54-b230-b513-c3cd-06ec8710d5d5@RedHat.com>
Date:   Fri, 10 May 2019 11:07:19 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <f53b3ed0-0489-2b94-9f8d-d0120db0c0da@RedHat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 5/9/19 1:25 PM, Steve Dickson wrote:
> 
> 
> On 5/8/19 12:02 PM, Orion Poplawski wrote:
>> On 5/8/19 9:54 AM, Steve Dickson wrote:
>>>
>>>
>>> On 5/8/19 10:58 AM, Orion Poplawski wrote:
>>>> This fixes:
>>>>
>>>> /usr/lib/systemd/system/nfs-blkmap.service:10: PIDFile= references path below
>>>> legacy directory /var/run/, updating /var/run/blkmapd.pid → /run/blkmapd.pid;
>>>> please update the unit file accordingly.
>>> Shouldn't the apps also be updated? I know there is a symbolic 
>>> link... but just for completeness the pid files in both apps 
>>> should be updated as well. 
>>>
>>> steved.
>>
>> I thought about that - but was concerned about legacy systems that still use
>> /var/run.
> Any idea how long the symlink will be around? But I do see your point.
> 
> steved.
> 
>>
>>>>
>>>> Signed-off-by: Orion Poplawski <orion@nwra.com>
>>>> ---
>>>>  systemd/nfs-blkmap.service | 2 +-
>>>>  systemd/rpc-statd.service  | 2 +-
>>>>  2 files changed, 2 insertions(+), 2 deletions(-)
Committed.... 

steved.

>>>>
>>>> diff --git a/systemd/nfs-blkmap.service b/systemd/nfs-blkmap.service
>>>> index 2bbcee6..6aa45ba 100644
>>>> --- a/systemd/nfs-blkmap.service
>>>> +++ b/systemd/nfs-blkmap.service
>>>> @@ -9,7 +9,7 @@ PartOf=nfs-utils.service
>>>>
>>>>  [Service]
>>>>  Type=forking
>>>> -PIDFile=/var/run/blkmapd.pid
>>>> +PIDFile=/run/blkmapd.pid
>>>>  ExecStart=/usr/sbin/blkmapd
>>>>
>>>>  [Install]
>>>> diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service
>>>> index 3e92cf7..095629f 100644
>>>> --- a/systemd/rpc-statd.service
>>>> +++ b/systemd/rpc-statd.service
>>>> @@ -13,5 +13,5 @@ IgnoreOnIsolate=yes
>>>>  [Service]
>>>>  Environment=RPC_STATD_NO_NOTIFY=1
>>>>  Type=forking
>>>> -PIDFile=/var/run/rpc.statd.pid
>>>> +PIDFile=/run/rpc.statd.pid
>>>>  ExecStart=/usr/sbin/rpc.statd
>>>> --
>>>> 1.8.3.1
>>>>
>>
>>