Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] nfs-utils: nfsidmap fail to build if no --with-pluginpath
 specified
To:     Yongcheng Yang <yongcheng.yang@gmail.com>
Cc:     linux-nfs@vger.kernel.org
References: <20190402091651.17186-1-yongcheng.yang@gmail.com>
 <95e49187-6d99-4168-1bb1-4a3f6f2500ee@RedHat.com>
 <20190417092246.GA5865@yoyang-pc.usersys.redhat.com>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <6c2d66ec-a098-72d6-42ab-15c3baa06f30@RedHat.com>
Date:   Fri, 10 May 2019 14:49:17 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190417092246.GA5865@yoyang-pc.usersys.redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 4/17/19 5:22 AM, Yongcheng Yang wrote:
> Hi SteveD,
> 
> On Tue, Apr 16, 2019 at 10:34:51AM -0400, Steve Dickson wrote:
>> The only way I see a failure is when ./configure --with-pluginpath= 
>> without a path which is wrong... 
>>
>> ./configure --with-pluginpath=/usr/lib/libnfsidmap seems to work
>> just fine
>>
>> I thinking it is better to error out when a path is not given
>> then to gloss over but used a default.
>>
>> steved.
>>
> 
> From what you comments, there should be a plugin path assigned by
> default if the user is not aware of it, correct?
> 
> Surely "./configure --with-pluginpath=/usr/lib/libnfsidmap" can work.
> But I didn't know the specific exact path before.
> 
> I was just using "./configure" without any options and find out that
> it's empty. (Please find my previous full logs)
> 
> Agree with you we should "use a default" one when path is not given.
Change of mind.... I think the patch is good... 

Committed! thanks!!

steved.
> 
> Thanks,
> Yongcheng
>