Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5204967yba; Mon, 13 May 2019 07:08:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxvTMaGOQvE5OMZ54apkVa/85OXZAX1gFVUjgAJj1UpvQK//ItX4KxHdhiEfK8jyNv4qEGX X-Received: by 2002:a65:614a:: with SMTP id o10mr14023301pgv.258.1557756500733; Mon, 13 May 2019 07:08:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557756500; cv=none; d=google.com; s=arc-20160816; b=a9toy4XwdevA0mB+v4DU2OJPzPHOsfMAmYJUUqIW2t7KTdMxD9aXEpRhX930wo46yM zJgZ+Pyjgbpy+w3w8oZqVJq1GDvbpAoztqvdvccz0qQ1Hf5QqAnRsc8QCtfqbl7oumSC KklPdGkxHtr14keEKFSKCl4RBKpZkBj8lJBvtR8vbYL3y3xyOz+f1ohhKK7IbsHA1c9A Vog+A5kiwLWtG1XhDaO0OMhFrBoywIQbGKvZ0YqPH/bZ2Y/DylzN1SA4v7dZ4iPLzzgD 89lZpB8bFIjTkx00STDrDMQJ/Sjf28Cwtvg5S1wy2NbUOI4IYSaI2Le6v5w2W7crxx0T pkHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=jE2A8yMJ5mMHU+Xt59DuANj75ZpLwD1tphK/zrCdp84=; b=FaIpf3X2C895zUcNG3TfA3eRWIKu1Npn8OsWNhF68azCkydKTRZOCB+B7FbuRdT1zZ owvjHnBAmjAMFuiE0vwI/SaTdtZWknW7fSAzsfDIy3rXamOjdayo2nIA6CYRuzOqF4bI 9nwt5dYQZLjSNtdtbyNJxpHOx52443DFwXtOBy4rB+bDRnBtlVws5GTI9rdLZsXDH+FY BfMgUkT3KonP1eOxvjzmPjI20kYU3VikXI97eMjqV4ChWwyhLWUOk79uxszLppCaso3E 1a3IxLElHlsc9Nb5TBxJo8Dsihe+E+YmnIcFZD2AgvIXKkNW4BprubylVj1JObRBekzS kk7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=r8AIQNmm; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f34si17303803plf.258.2019.05.13.07.08.06; Mon, 13 May 2019 07:08:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=r8AIQNmm; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729516AbfEMNgY (ORCPT + 99 others); Mon, 13 May 2019 09:36:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:59384 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727202AbfEMNgY (ORCPT ); Mon, 13 May 2019 09:36:24 -0400 Received: from vulcan.poochiereds.net (cpe-71-70-156-158.nc.res.rr.com [71.70.156.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F183208C2; Mon, 13 May 2019 13:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557754583; bh=KvQDNwu3bULD+Ywks8ZVEWJR/s9gauUg+Iqux0u6+Nc=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=r8AIQNmm1hKdp3IMk/Do7SlsNWzd6EdiSIZWPezRYQZNGDoOOy/kkOcxwzHFR6jj2 p8aTRCxU/xLif/TvDG/P9up5MRy3u1ytXpTeloaPNU6gO47vu97WEyvoi2orLwtrrb pj7znLXDqTcmRKPmkEHeUcUWq3CuaB2uxirDZdhY= Message-ID: <0d422bbcce15e44a4608cced0a569585c75ccd9a.camel@kernel.org> Subject: Re: [PATCH v2 0/2] Fix two bugs CB_NOTIFY_LOCK failing to wake a water From: Jeff Layton To: Yihao Wu , linux-nfs@vger.kernel.org, "J. Bruce Fields" Cc: Joseph Qi , caspar@linux.alibaba.com Date: Mon, 13 May 2019 09:36:21 -0400 In-Reply-To: <346806ac-2018-b780-4939-87f29648017c@linux.alibaba.com> References: <346806ac-2018-b780-4939-87f29648017c@linux.alibaba.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.1 (3.32.1-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, 2019-05-13 at 14:49 +0800, Yihao Wu wrote: > This patch set fix bugs related to CB_NOTIFY_LOCK. These bugs cause > poor performance in locking operation. And this patchset should also fix > the failure when running xfstests generic/089 on a NFSv4.1 filesystem. > > Yihao Wu (2): > NFSv4.1: Again fix a race where CB_NOTIFY_LOCK fails to wake a waiter > NFSv4.1: Fix bug only first CB_NOTIFY_LOCK is handled > > fs/nfs/nfs4proc.c | 31 ++++++++++++------------------- > 1 file changed, 12 insertions(+), 19 deletions(-) > Looks good to me. Nice catch, btw! Reviewed-by: Jeff Layton