Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 0/2] Fix two bugs CB_NOTIFY_LOCK failing to wake a
 water
To:     Jeff Layton <jlayton@kernel.org>, linux-nfs@vger.kernel.org,
        "J. Bruce Fields" <bfields@fieldses.org>
Cc:     Joseph Qi <joseph.qi@linux.alibaba.com>, caspar@linux.alibaba.com,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>
References: <346806ac-2018-b780-4939-87f29648017c@linux.alibaba.com>
 <0d422bbcce15e44a4608cced0a569585c75ccd9a.camel@kernel.org>
From:   Yihao Wu <wuyihao@linux.alibaba.com>
Message-ID: <1a3d5e35-50bc-d757-5d30-15b1c8cff9ad@linux.alibaba.com>
Date:   Thu, 16 May 2019 16:01:23 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <0d422bbcce15e44a4608cced0a569585c75ccd9a.camel@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On 2019/5/13 9:36 PM, Jeff Layton wrote:
> On Mon, 2019-05-13 at 14:49 +0800, Yihao Wu wrote:
>> This patch set fix bugs related to CB_NOTIFY_LOCK. These bugs cause
>> poor performance in locking operation. And this patchset should also fix
>> the failure when running xfstests generic/089 on a NFSv4.1 filesystem.
>>
>> Yihao Wu (2):
>>   NFSv4.1: Again fix a race where CB_NOTIFY_LOCK fails to wake a waiter
>>   NFSv4.1: Fix bug only first CB_NOTIFY_LOCK is handled
>>
>>  fs/nfs/nfs4proc.c | 31 ++++++++++++-------------------
>>  1 file changed, 12 insertions(+), 19 deletions(-)
>>
> 
> Looks good to me. Nice catch, btw!
> 
> Reviewed-by: Jeff Layton <jlayton@kernel.org>
> 

Thank you for your reviewing, Jeff!

And it seems I forgot to CC maintainers of fs/nfs. So I added you to the CC
list, Trond and Anna. Does this patchset need further reviewing?

Sorry to bother you.

Thanks,
Yihao Wu