Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH net-next] xprtrdma: Use struct_size() in kzalloc()
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <70ca0dea-6f1f-922c-7c5d-e79c6cf6ecb5@embeddedor.com>
Date:   Thu, 23 May 2019 19:02:39 -0400
Cc:     Trond Myklebust <trond.myklebust@hammerspace.com>,
        Bruce Fields <bfields@fieldses.org>,
        Jeff Layton <jlayton@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <CDDB9617-08B2-43B6-AB03-3BAA7CC27839@oracle.com>
References: <20190131004622.GA30261@embeddedor>
 <07CB966E-A946-4956-8480-C0FC13E13E4E@oracle.com>
 <ad9eccc7-afd2-3419-b886-6210eeabd5b5@embeddedor.com>
 <70ca0dea-6f1f-922c-7c5d-e79c6cf6ecb5@embeddedor.com>
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Anna Schumaker <anna.schumaker@netapp.com>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

Hi Gustavo-

Anna is supposed to take patches for xprtrdma/ .


> On May 23, 2019, at 6:36 PM, Gustavo A. R. Silva =
<gustavo@embeddedor.com> wrote:
>=20
> Hi Dave,
>=20
> I wonder if you can take this patch.
>=20
> Thanks
> --
> Gustavo
>=20
> On 3/28/19 3:41 PM, Gustavo A. R. Silva wrote:
>> Hi all,
>>=20
>> Friendly ping:
>>=20
>> Who can take this?
>>=20
>> Thanks
>> --
>> Gustavo
>>=20
>> On 1/31/19 8:11 AM, Chuck Lever wrote:
>>>=20
>>>=20
>>>> On Jan 30, 2019, at 7:46 PM, Gustavo A. R. Silva =
<gustavo@embeddedor.com> wrote:
>>>>=20
>>>> One of the more common cases of allocation size calculations is =
finding
>>>> the size of a structure that has a zero-sized array at the end, =
along
>>>> with memory for some number of elements for that array. For =
example:
>>>>=20
>>>> struct foo {
>>>>   int stuff;
>>>>   struct boo entry[];
>>>> };
>>>>=20
>>>> instance =3D kzalloc(sizeof(struct foo) + count * sizeof(struct =
boo), GFP_KERNEL);
>>>>=20
>>>> Instead of leaving these open-coded and prone to type mistakes, we =
can
>>>> now use the new struct_size() helper:
>>>>=20
>>>> instance =3D kzalloc(struct_size(instance, entry, count), =
GFP_KERNEL);
>>>>=20
>>>> This code was detected with the help of Coccinelle.
>>>>=20
>>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>>=20
>>> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
>>>=20
>>>=20
>>>> ---
>>>> net/sunrpc/xprtrdma/verbs.c | 3 +--
>>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>>=20
>>>> diff --git a/net/sunrpc/xprtrdma/verbs.c =
b/net/sunrpc/xprtrdma/verbs.c
>>>> index 4994e75945b8..9e8cf7456840 100644
>>>> --- a/net/sunrpc/xprtrdma/verbs.c
>>>> +++ b/net/sunrpc/xprtrdma/verbs.c
>>>> @@ -811,8 +811,7 @@ static struct rpcrdma_sendctx =
*rpcrdma_sendctx_create(struct rpcrdma_ia *ia)
>>>> {
>>>> 	struct rpcrdma_sendctx *sc;
>>>>=20
>>>> -	sc =3D kzalloc(sizeof(*sc) +
>>>> -		     ia->ri_max_send_sges * sizeof(struct ib_sge),
>>>> +	sc =3D kzalloc(struct_size(sc, sc_sges, ia->ri_max_send_sges),
>>>> 		     GFP_KERNEL);
>>>> 	if (!sc)
>>>> 		return NULL;
>>>> --=20
>>>> 2.20.1
>>>>=20
>>>=20
>>> --
>>> Chuck Lever
>>>=20
>>>=20
>>>=20

--
Chuck Lever