Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Benjamin Coddington" <bcodding@redhat.com>
To:     "J. Bruce Fields" <bfields@fieldses.org>
Cc:     "J . Bruce Fields" <bfields@redhat.com>, jlayton@kernel.org,
        linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 0/5] NLM fl_pid fixup
Date:   Sat, 25 May 2019 07:09:17 -0400
Message-ID: <114775E1-D195-4DE1-8920-CC750DBB44C2@redhat.com>
In-Reply-To: <20190524164759.GA23881@fieldses.org>
References: <cover.1558622651.git.bcodding@redhat.com>
 <20190524164759.GA23881@fieldses.org>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 24 May 2019, at 12:47, J. Bruce Fields wrote:

> On Thu, May 23, 2019 at 10:45:43AM -0400, Benjamin Coddington wrote:
>> This series aims to correct the fl_pid value for locks held by the 
>> NLM
>> server, or lockd.  It applies onto the revert of the previous attempt 
>> to fix
>> this problem sent ealier this week: '[PATCH] Revert "lockd: Show pid 
>> of
>> lockd for remote locks"'.
>>
>> The problem with the earlier attempt was that we discarded the svid, 
>> and so
>> we couldn't distinguish remote lockowners on each host.  It is 
>> necessary to
>> turn the svid and host into a distinct owner.
>
> So, to make sure I understand, we've got multiple ways to identify a
> lock owner:
>
> 	- the svid, the pid of the client process: this gets returned to
> 	  the client in grant callbacks and (possibly to a different
> 	  client) in testd results.
> 	- the pid of the server's lockd process: this is what other
> 	  processes on the server see as the owner of locks held by nfs
> 	  clients.
> 	- the nlm_lockowner: a (nlm_host, svid) pair, used to actually
> 	  decide when locks conflict.

That's it.

> Makes sense to me.
>
> I'll send your earlier revert to stable, then add this on top for the
> 5.3 merge window.  Sound OK?

Sounds great, thank you!

Ben