Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH -next] lockd: Make two symbols static
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <20190528151331.GA29554@fieldses.org>
Date:   Tue, 28 May 2019 11:19:53 -0400
Cc:     Benjamin Coddington <bcodding@redhat.com>,
        YueHaibing <yuehaibing@huawei.com>, jlayton@kernel.org,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Transfer-Encoding: 7bit
Message-Id: <534DECA5-DFC5-497C-8023-6D7F859F8148@oracle.com>
References: <20190528090652.13288-1-yuehaibing@huawei.com>
 <97D052EC-1F07-4210-81CC-7E0085C095BD@redhat.com>
 <20190528151331.GA29554@fieldses.org>
To:     Bruce Fields <bfields@fieldses.org>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On May 28, 2019, at 11:13 AM, J. Bruce Fields <bfields@fieldses.org> wrote:
> 
> On Tue, May 28, 2019 at 06:49:13AM -0400, Benjamin Coddington wrote:
>> Maintainers, what's the best thing to do here: fold these into
>> another patch version and post it (add attribution)?  Add it as
>> another patch at the end of the series?
> 
> Either would be fine.  Yeah, if it was folded in then we'd add a line
> like
> 
> 	[hulkci@huawei.com: make symbols static to fix sparse warnings]
> 
> But I'll probably just add it on to the end for now.  No need for you to
> do anything.
> 
>> I have learned my lesson: add sparse to my workflow.
> 
> I dunno, I wonder if we're better off just leaving it to this CI bot.
> It seems like a more efficient use of time overall than making every
> contributor run it.

Occasionally sparse can catch a real problem that breaks bisectability.
Better to do this kind of checking early, and ensure that you test those
sparse-fixed bits.


--
Chuck Lever